From 95a3063ce0352245b3708296bd88af6b2f513fac Mon Sep 17 00:00:00 2001 From: Dennis Kniep Date: Tue, 9 Jan 2024 21:43:42 +0100 Subject: [PATCH] Remove max validation for namepsace.workflowExecutionRetentionDays property --- OWNERS.md | 12 ++---------- README.md | 5 ++--- apis/core/v1alpha1/temporalnamespace_types.go | 1 - ...re.temporal.crossplane.io_temporalnamespaces.yaml | 1 - 4 files changed, 4 insertions(+), 15 deletions(-) diff --git a/OWNERS.md b/OWNERS.md index 1a803d4..2ad7f80 100644 --- a/OWNERS.md +++ b/OWNERS.md @@ -1,15 +1,7 @@ # OWNERS -This page lists all maintainers for **this** repository. Each repository in the [Crossplane -organization](https://github.com/crossplane/) will list their repository maintainers in their own -`OWNERS.md` file. - -Please see the Crossplane -[GOVERNANCE.md](https://github.com/crossplane/crossplane/blob/master/GOVERNANCE.md) for governance -guidelines and responsibilities for the steering committee and maintainers. +This page lists all maintainers for **this** repository. ## Maintainers -* Nic Cope ([negz](https://github.com/negz)) -* Daniel Mangum ([hasheddan](https://github.com/hasheddan)) -* Muvaffak Onuş ([muvaf](https://github.com/muvaf)) +* Dennis Kniep ([denniskniep](https://github.com/denniskniep)) \ No newline at end of file diff --git a/README.md b/README.md index 2e8a7a6..c5ad2a8 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Temporal Provider -Provider Temporal is a [Crossplane](https://www.crossplane.io/) provider. It was build based on the [Crossplane Template](https://github.com/crossplane/provider-template). It is used to manage and configure [Temporal](https://temporal.io/). It uses the [Temporal Go SDK](https://github.com/temporalio/sdk-go) +Temporal Provider is a [Crossplane](https://www.crossplane.io/) provider. It was build based on the [Crossplane Template](https://github.com/crossplane/provider-template). It is used to manage and configure [Temporal](https://temporal.io/). It uses the [Temporal Go SDK](https://github.com/temporalio/sdk-go) # How to use Repository and package: @@ -169,8 +169,7 @@ spec: ``` 2. Replace the *core* group with your new group in apis/{provider}.go 3. Replace the *MyType* type with your new type in internal/controller/{provider}.go - -4. Run `make reviewable` to run code generation, linters, and tests. +4. Run `make reviewable` to run code generation, linters, and tests. (`make generate` to only run code generation) 5. Run `make build` to build the provider. Refer to Crossplane's [CONTRIBUTING.md] file for more information on how the diff --git a/apis/core/v1alpha1/temporalnamespace_types.go b/apis/core/v1alpha1/temporalnamespace_types.go index 0f515e2..de4dcae 100644 --- a/apis/core/v1alpha1/temporalnamespace_types.go +++ b/apis/core/v1alpha1/temporalnamespace_types.go @@ -42,7 +42,6 @@ type TemporalNamespaceParameters struct { // Workflow Execution retention. // +kubebuilder:default=30 // +kubebuilder:validation:Minimum=1 - // +kubebuilder:validation:Maximum=30 WorkflowExecutionRetentionDays int `json:"workflowExecutionRetentionDays,omitempty"` // +optional diff --git a/package/crds/core.temporal.crossplane.io_temporalnamespaces.yaml b/package/crds/core.temporal.crossplane.io_temporalnamespaces.yaml index 1c92b4a..81d837f 100644 --- a/package/crds/core.temporal.crossplane.io_temporalnamespaces.yaml +++ b/package/crds/core.temporal.crossplane.io_temporalnamespaces.yaml @@ -101,7 +101,6 @@ spec: workflowExecutionRetentionDays: default: 30 description: Workflow Execution retention. - maximum: 30 minimum: 1 type: integer required: