Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Books as Detection Terms? #33

Open
toolworker opened this issue Jul 29, 2023 · 7 comments
Open

Address Books as Detection Terms? #33

toolworker opened this issue Jul 29, 2023 · 7 comments

Comments

@toolworker
Copy link

I use address books as filter elements to route incoming emails to the correct folder. If Correct Identity could accept an address book as a detection term, it would use the correct identity for all those people. And adding an address to an address book would also add it to the detection terms.

@ldreier
Copy link
Collaborator

ldreier commented Aug 7, 2023

Hi,

I made some test implementation for your address-book proposal and pushed some changes to this repository.
For testing you could use correct_identity_latest.xpi.

As an example you can add the following line to the text field:
addressbook="Test Address Book"

The string in quotes is the name of the address book as given in the
address book pane. Can be copied from address book properties.

Please check if this covers your idea...

@toolworker
Copy link
Author

Thanks, Dennis! This is fantastically useful!

One problem - when there are two address books specified, it only searches the first one. I think it stops searching after that. But even with that bug, it's very useful. I just place the address book last in the list.

@ldreier
Copy link
Collaborator

ldreier commented Sep 4, 2023

The problem should be fixed now ... removed one line of code.
Updated correct_identity_latest.xpi.

@WalZyl
Copy link

WalZyl commented Mar 17, 2024

I'm just curious if the address-book feature works in the the version 2.3.2 ? Actually, for me it stopped to work after March, 6th, 2024. It was, is and will be so useful !!

@toolworker
Copy link
Author

I love this feature! But it's not working now for me either in 2.3.2. I backed out to a version Dennis gave me last fall and that one does work.

@WalZyl
Copy link

WalZyl commented Mar 17, 2024

@ldreier: seems that the address-book feature is not in the main branch (so automatic updates will over-write special versions). Any chance to include it in the main branch of this add-on ?

@ldreier
Copy link
Collaborator

ldreier commented Mar 18, 2024

@toolworker , @WalZyl
The "address-book feature" was not part of version 2.3.2 (which was released in June 2023).
I plan to start the release process for a new version in the next days after fixing the uppercase/lowercase issue for the pattern matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants