From 36d8e5e798c86ec2cc19529a4068a5104441c493 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 1 Mar 2024 20:10:10 +0000 Subject: [PATCH 1/2] Bump rubocop-rspec from 2.26.1 to 2.27.0 Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 2.26.1 to 2.27.0. - [Release notes](https://github.com/rubocop/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.26.1...v2.27.0) --- updated-dependencies: - dependency-name: rubocop-rspec dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index e628d69a2..eac09ad0e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -667,9 +667,8 @@ GEM rubocop-ast (>= 1.30.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 2.4.0, < 3.0) - rubocop-ast (1.31.0) + rubocop-ast (1.31.1) parser (>= 3.3.0.4) - prism (>= 0.24.0) rubocop-capybara (2.20.0) rubocop (~> 1.41) rubocop-factory_bot (2.25.1) @@ -682,7 +681,7 @@ GEM rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) rubocop-ast (>= 1.30.0, < 2.0) - rubocop-rspec (2.26.1) + rubocop-rspec (2.27.0) rubocop (~> 1.40) rubocop-capybara (~> 2.17) rubocop-factory_bot (~> 2.22) From c445d4dd023f8e07a404afdb026d416277a0726f Mon Sep 17 00:00:00 2001 From: Denny <2023@denny.me> Date: Fri, 1 Mar 2024 21:06:30 +0000 Subject: [PATCH 2/2] Fix minor rubocop complaints --- plugins/ShinyCMS/spec/models/shinycms/setting_spec.rb | 2 +- plugins/ShinyCMS/spec/other/i18n_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/ShinyCMS/spec/models/shinycms/setting_spec.rb b/plugins/ShinyCMS/spec/models/shinycms/setting_spec.rb index a35e84ce0..eb03689d2 100644 --- a/plugins/ShinyCMS/spec/models/shinycms/setting_spec.rb +++ b/plugins/ShinyCMS/spec/models/shinycms/setting_spec.rb @@ -42,7 +42,7 @@ setting.level = 'user' expect { _rbp = setting.save( validate: false ) } - .to raise_error ShinyCMS::Setting::CannotUpdateLockedSetting, 'Attempted to update a locked setting' + .to raise_error described_class::CannotUpdateLockedSetting, 'Attempted to update a locked setting' end end diff --git a/plugins/ShinyCMS/spec/other/i18n_spec.rb b/plugins/ShinyCMS/spec/other/i18n_spec.rb index de436a19a..27c14cfd1 100644 --- a/plugins/ShinyCMS/spec/other/i18n_spec.rb +++ b/plugins/ShinyCMS/spec/other/i18n_spec.rb @@ -13,9 +13,9 @@ # Tests to check i18n strings are all present and current RSpec.describe I18n do - let( :i18n ) { I18n::Tasks::BaseTask.new } - let( :missing_keys ) { i18n.missing_keys } - let( :unused_keys ) { i18n.unused_keys } + let( :i18n ) { described_class::Tasks::BaseTask.new } + let( :missing_keys ) { i18n.missing_keys } + let( :unused_keys ) { i18n.unused_keys } it 'does not have missing keys' do error_message = "Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"