Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJML binary attempting to make Internet connection every time it's run? #891

Open
denny opened this issue Jan 28, 2021 · 1 comment
Open
Labels
javascript Involves JavaScript code, or webpacker etc mjml Involves MJML, or the code that handles it ruby Involves Ruby code

Comments

@denny
Copy link
Owner

denny commented Jan 28, 2021

Tests of MJML mailers (Forms, Newsletters, etc) throw this warning when run offline:
"Mjml: warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries."

The Newsletter plugin tests tend to top the 'slowest tests' list, which could be related - network delays rather than slow or complicated code.

@denny denny added javascript Involves JavaScript code, or webpacker etc mjml Involves MJML, or the code that handles it labels Jan 28, 2021
@denny
Copy link
Owner Author

denny commented Feb 16, 2021

Did a bit of digging into this and running the mjml commands on the command line doesn't trigger the same warning, so it would appear to be something about how the Ruby gem uses it? Need to create an isolated test case next, I think.

@denny denny added inexplicably complicated Probably not a good first bug! ruby Involves Ruby code and removed inexplicably complicated Probably not a good first bug! labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Involves JavaScript code, or webpacker etc mjml Involves MJML, or the code that handles it ruby Involves Ruby code
Projects
None yet
Development

No branches or pull requests

1 participant