From c38c14f51f2edc8d25f349de52fc1268b97b59b2 Mon Sep 17 00:00:00 2001 From: Asher Gomez Date: Tue, 12 Mar 2024 14:31:34 +1100 Subject: [PATCH] chore: make Node setup script less sensitive to changes (#22855) This change tweaks the Node setup script less sensitive to changes by removing the test counter line in `tools/node_compat/TODO.md`. Previously, this line would cause linting issues when two Node compat changes occured one after another. See https://github.com/denoland/deno/actions/runs/8226735149/job/22493585874 Signed-off-by: Asher Gomez --- tools/node_compat/TODO.md | 2 -- tools/node_compat/setup.ts | 2 -- 2 files changed, 4 deletions(-) diff --git a/tools/node_compat/TODO.md b/tools/node_compat/TODO.md index 8321ae1df3aa21..88cadfc1c34af6 100644 --- a/tools/node_compat/TODO.md +++ b/tools/node_compat/TODO.md @@ -3,8 +3,6 @@ NOTE: This file should not be manually edited. Please edit `tests/node_compat/config.json` and run `deno task setup` in `tools/node_compat` dir instead. -Total: 2996 - - [abort/test-abort-backtrace.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-backtrace.js) - [abort/test-abort-fatal-error.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-fatal-error.js) - [abort/test-abort-uncaught-exception.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-uncaught-exception.js) diff --git a/tools/node_compat/setup.ts b/tools/node_compat/setup.ts index 0ead46e250fed8..50dba393c703b8 100755 --- a/tools/node_compat/setup.ts +++ b/tools/node_compat/setup.ts @@ -78,8 +78,6 @@ async function updateToDo() { NOTE: This file should not be manually edited. Please edit \`tests/node_compat/config.json\` and run \`deno task setup\` in \`tools/node_compat\` dir instead. -Total: ${missingTests.length} - `)); for (const test of missingTests) { await file.write(