Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno 2.1.6 panics with required type deno_os::ops::signal::SignalState is not present in GothamState container #27717

Closed
lambdalisue opened this issue Jan 18, 2025 · 1 comment · Fixed by #27741
Labels
bug Something isn't working correctly

Comments

@lambdalisue
Copy link

Version: Deno 2.1.6

[denops] Deno has panicked. This is a bug in Deno. Please report this
[denops] at https://github.com/denoland/deno/issues/new.
[denops] If you can reliably reproduce this panic, include the
[denops] reproduction steps and re-run with the RUST_BACKTRACE=1 env
[denops] var set and include the backtrace in your report.
[denops] 
[denops] Platform: linux x86_64
[denops] Version: 2.1.6
[denops] Args: ["/tmp/deno-2.1.6", "run
[denops] ", "-q", "--no-lock", "-A", "/tmp/denops.vim/denops/@denops-private/cli.ts", "--quiet", "--identity", "--port", "0"]
[denops] 
[denops] thread 'worker-1' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.330.0/gotham_state.rs:74:3:
[denops] required type deno_os::ops::signal::SignalState is not present in GothamState container
[denops] stack backtrace:
[denops]    0: rust_begin_unwind
[denops]    1: core::panicking::panic_fmt
[denops]    2: deno_core::gotham_state::missing
[denops]    3: deno_os::ops::signal::op_signal_bind::op_signal_bind::call
[denops]    4: deno_os::ops::signal::op_signal_bind::op_signal_bind::slow_function_impl
[denops]    5: deno_os::ops::signal::op_signal_bind::op_signal_bind::v8_fn_ptr
[denops]    6: Builtins_CallApiCallbackGeneric
[denops] note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
@bartlomieju
Copy link
Member

bartlomieju commented Jan 20, 2025

Do you happen to have a minimal reproduction?

EDIT: Actually nevermind, I know what the problem is

@bartlomieju bartlomieju added the bug Something isn't working correctly label Jan 20, 2025
bartlomieju added a commit that referenced this issue Jan 20, 2025
Closes #27717

Made a mistake in #27655 and
didn't add the `SignalStore` for web worker.
crowlKats pushed a commit that referenced this issue Jan 21, 2025
Closes #27717

Made a mistake in #27655 and
didn't add the `SignalStore` for web worker.

(cherry picked from commit 3956280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants