Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: Renaming variables doesn't updated shorthand property names correctly #28074

Open
jespertheend opened this issue Feb 12, 2025 · 1 comment
Labels
lsp related to the language server

Comments

@jespertheend
Copy link
Contributor

Version: Deno 2.1.9

function foo({myParam}: {myParam: number}) {
    console.log(myParam);
}

const myParam = 3; // select myParam and hit F2 to rename
foo({myParam})

Normally when you rename myParam using the F2 key, VSCode turns the last line into:

foo({myParam: newParam})

But when you perform this same trick with Deno, you get:

foo({newParam})
@bartlomieju
Copy link
Member

bartlomieju commented Feb 12, 2025

I can't reproduce the problem:

Screen.Recording.2025-02-12.at.11.08.45.mov

Err, nevermind, I read the issue wrong. I can reproduce the problem.

@bartlomieju bartlomieju added the lsp related to the language server label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp related to the language server
Projects
None yet
Development

No branches or pull requests

2 participants