Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp tracing: support changing deno.tracing config while lsp is running #28093

Open
nathanwhit opened this issue Feb 12, 2025 · 0 comments
Open

Comments

@nathanwhit
Copy link
Member

nathanwhit commented Feb 12, 2025

Right now if you change the tracing config, you have to restart the LSP for the changes to take effect.

I originally tried this, but there's some bug when setting the tracing subscriber as a thread local default (as opposed to global) that causes spans to lose their parents. It may be an issue with the otel exporter, but not sure.

cc #27843

@nathanwhit nathanwhit changed the title lsp tracing: allow changing deno.tracing config while lsp is running lsp tracing: support changing deno.tracing config while lsp is running Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant