From 6b28b204adc186ba2e8b01f9e25690601e0fd9be Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Sat, 4 Jan 2025 09:53:11 +0530 Subject: [PATCH 1/2] Allow too many args in op calls --- ops/op2/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ops/op2/mod.rs b/ops/op2/mod.rs index 11750a900..e57f59f59 100644 --- a/ops/op2/mod.rs +++ b/ops/op2/mod.rs @@ -288,7 +288,7 @@ pub(crate) fn generate_op2( #op_fn_sig; } impl Callable for #ident { - #[inline(always)] + #[allow(clippy::too_many_arguments)] #(#attrs)* #op_fn } @@ -296,7 +296,7 @@ pub(crate) fn generate_op2( } else { quote! { impl <#(#generic : #bound),*> #rust_name <#(#generic),*> { - #[inline(always)] + #[allow(clippy::too_many_arguments)] #(#attrs)* #op_fn } From 8032bd16f2dad4cd5d4cd168b680d2b090d0649a Mon Sep 17 00:00:00 2001 From: Divy Srivastava Date: Sat, 4 Jan 2025 10:30:48 +0530 Subject: [PATCH 2/2] lint --- ops/op2/test_cases/async/async_arg_return.out | 2 +- .../async/async_arg_return_result.out | 2 +- ops/op2/test_cases/async/async_cppgc.out | 6 +++--- ops/op2/test_cases/async/async_deferred.out | 2 +- ops/op2/test_cases/async/async_jsbuffer.out | 2 +- ops/op2/test_cases/async/async_lazy.out | 2 +- ops/op2/test_cases/async/async_op_metadata.out | 4 ++-- ops/op2/test_cases/async/async_opstate.out | 2 +- ops/op2/test_cases/async/async_result.out | 2 +- ops/op2/test_cases/async/async_result_impl.out | 2 +- ops/op2/test_cases/async/async_result_smi.out | 2 +- ops/op2/test_cases/async/async_stack_trace.out | 2 +- ops/op2/test_cases/async/async_v8_global.out | 2 +- ops/op2/test_cases/async/async_void.out | 2 +- ops/op2/test_cases/sync/add.out | 2 +- ops/op2/test_cases/sync/add_options.out | 2 +- ops/op2/test_cases/sync/bigint.out | 2 +- ops/op2/test_cases/sync/bool.out | 2 +- ops/op2/test_cases/sync/bool_result.out | 2 +- ops/op2/test_cases/sync/buffers.out | 6 +++--- ops/op2/test_cases/sync/buffers_copy.out | 4 ++-- ops/op2/test_cases/sync/buffers_out.out | 6 +++--- ops/op2/test_cases/sync/cfg.out | 4 ++-- ops/op2/test_cases/sync/clippy_allow.out | 4 ++-- ops/op2/test_cases/sync/cppgc_resource.out | 12 ++++++------ ops/op2/test_cases/sync/doc_comment.out | 2 +- ops/op2/test_cases/sync/fast_alternative.out | 8 ++++---- ops/op2/test_cases/sync/from_v8.out | 2 +- ops/op2/test_cases/sync/generics.out | 6 +++--- ops/op2/test_cases/sync/nofast.out | 2 +- ops/op2/test_cases/sync/object_wrap.out | 18 +++++++++--------- ops/op2/test_cases/sync/op_state_attr.out | 2 +- ops/op2/test_cases/sync/op_state_rc.out | 2 +- ops/op2/test_cases/sync/op_state_ref.out | 8 ++++---- ops/op2/test_cases/sync/result_external.out | 2 +- ops/op2/test_cases/sync/result_primitive.out | 2 +- ops/op2/test_cases/sync/result_scope.out | 2 +- ops/op2/test_cases/sync/result_void.out | 2 +- ops/op2/test_cases/sync/serde_v8.out | 2 +- ops/op2/test_cases/sync/smi.out | 6 +++--- ops/op2/test_cases/sync/stack_trace.out | 2 +- ops/op2/test_cases/sync/stack_trace_scope.out | 2 +- ops/op2/test_cases/sync/string_cow.out | 2 +- ops/op2/test_cases/sync/string_onebyte.out | 2 +- .../test_cases/sync/string_option_return.out | 2 +- ops/op2/test_cases/sync/string_owned.out | 2 +- ops/op2/test_cases/sync/string_ref.out | 2 +- ops/op2/test_cases/sync/string_return.out | 6 +++--- ops/op2/test_cases/sync/to_v8.out | 2 +- ops/op2/test_cases/sync/v8_global.out | 2 +- ops/op2/test_cases/sync/v8_handlescope.out | 2 +- ops/op2/test_cases/sync/v8_lifetime.out | 2 +- ops/op2/test_cases/sync/v8_ref_option.out | 2 +- ops/op2/test_cases/sync/v8_string.out | 2 +- ops/op2/test_cases/sync/webidl.out | 2 +- 55 files changed, 90 insertions(+), 90 deletions(-) diff --git a/ops/op2/test_cases/async/async_arg_return.out b/ops/op2/test_cases/async/async_arg_return.out index e6794157e..9a7610ffb 100644 --- a/ops/op2/test_cases/async/async_arg_return.out +++ b/ops/op2/test_cases/async/async_arg_return.out @@ -112,7 +112,7 @@ pub const fn op_async() -> ::deno_core::_ops::OpDecl { } } impl op_async { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call(x: i32) -> i32 { x } diff --git a/ops/op2/test_cases/async/async_arg_return_result.out b/ops/op2/test_cases/async/async_arg_return_result.out index 0e3f3a9c0..12ad8fb0c 100644 --- a/ops/op2/test_cases/async/async_arg_return_result.out +++ b/ops/op2/test_cases/async/async_arg_return_result.out @@ -129,7 +129,7 @@ pub const fn op_async() -> ::deno_core::_ops::OpDecl { } } impl op_async { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call(x: i32) -> std::io::Result { Ok(x) } diff --git a/ops/op2/test_cases/async/async_cppgc.out b/ops/op2/test_cases/async/async_cppgc.out index 0d3d376b3..69cdd08fd 100644 --- a/ops/op2/test_cases/async/async_cppgc.out +++ b/ops/op2/test_cases/async/async_cppgc.out @@ -115,7 +115,7 @@ const fn op_make_cppgc_object() -> ::deno_core::_ops::OpDecl { } } impl op_make_cppgc_object { - #[inline(always)] + #[allow(clippy::too_many_arguments)] async fn call() -> Wrap { Wrap } @@ -242,7 +242,7 @@ const fn op_use_cppgc_object() -> ::deno_core::_ops::OpDecl { } } impl op_use_cppgc_object { - #[inline(always)] + #[allow(clippy::too_many_arguments)] async fn call(_wrap: &Wrap) {} } ::DECL @@ -371,7 +371,7 @@ const fn op_use_optional_cppgc_object() -> ::deno_core::_ops::OpDecl { } } impl op_use_optional_cppgc_object { - #[inline(always)] + #[allow(clippy::too_many_arguments)] async fn call(_wrap: Option<&Wrap>) {} } ::DECL diff --git a/ops/op2/test_cases/async/async_deferred.out b/ops/op2/test_cases/async/async_deferred.out index c447f4ff1..970fe6328 100644 --- a/ops/op2/test_cases/async/async_deferred.out +++ b/ops/op2/test_cases/async/async_deferred.out @@ -190,7 +190,7 @@ pub const fn op_async_deferred() -> ::deno_core::_ops::OpDecl { } } impl op_async_deferred { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call() -> std::io::Result { Ok(0) } diff --git a/ops/op2/test_cases/async/async_jsbuffer.out b/ops/op2/test_cases/async/async_jsbuffer.out index 02a9ff897..4a2c728f6 100644 --- a/ops/op2/test_cases/async/async_jsbuffer.out +++ b/ops/op2/test_cases/async/async_jsbuffer.out @@ -136,7 +136,7 @@ pub const fn op_async_v8_buffer() -> ::deno_core::_ops::OpDecl { } } impl op_async_v8_buffer { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call(buf: JsBuffer) -> JsBuffer { buf } diff --git a/ops/op2/test_cases/async/async_lazy.out b/ops/op2/test_cases/async/async_lazy.out index 948dfa9ed..2c72ec66a 100644 --- a/ops/op2/test_cases/async/async_lazy.out +++ b/ops/op2/test_cases/async/async_lazy.out @@ -190,7 +190,7 @@ pub const fn op_async_lazy() -> ::deno_core::_ops::OpDecl { } } impl op_async_lazy { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call() -> std::io::Result { Ok(0) } diff --git a/ops/op2/test_cases/async/async_op_metadata.out b/ops/op2/test_cases/async/async_op_metadata.out index 8f8045b43..ccfaa8fef 100644 --- a/ops/op2/test_cases/async/async_op_metadata.out +++ b/ops/op2/test_cases/async/async_op_metadata.out @@ -98,7 +98,7 @@ const fn op_blob_read_part() -> ::deno_core::_ops::OpDecl { } } impl op_blob_read_part { - #[inline(always)] + #[allow(clippy::too_many_arguments)] async fn call() { return; } @@ -206,7 +206,7 @@ const fn op_broadcast_recv() -> ::deno_core::_ops::OpDecl { } } impl op_broadcast_recv { - #[inline(always)] + #[allow(clippy::too_many_arguments)] async fn call() { return; } diff --git a/ops/op2/test_cases/async/async_opstate.out b/ops/op2/test_cases/async/async_opstate.out index bf82a040b..86997c843 100644 --- a/ops/op2/test_cases/async/async_opstate.out +++ b/ops/op2/test_cases/async/async_opstate.out @@ -117,7 +117,7 @@ pub const fn op_async_opstate() -> ::deno_core::_ops::OpDecl { } } impl op_async_opstate { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call(state: Rc>) -> std::io::Result { Ok(*state.borrow().borrow::()) } diff --git a/ops/op2/test_cases/async/async_result.out b/ops/op2/test_cases/async/async_result.out index 34efefc3c..3259975c2 100644 --- a/ops/op2/test_cases/async/async_result.out +++ b/ops/op2/test_cases/async/async_result.out @@ -113,7 +113,7 @@ pub const fn op_async() -> ::deno_core::_ops::OpDecl { } } impl op_async { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call() -> std::io::Result { Ok(0) } diff --git a/ops/op2/test_cases/async/async_result_impl.out b/ops/op2/test_cases/async/async_result_impl.out index ee648425f..59d459b5f 100644 --- a/ops/op2/test_cases/async/async_result_impl.out +++ b/ops/op2/test_cases/async/async_result_impl.out @@ -143,7 +143,7 @@ pub const fn op_async_result_impl() -> ::deno_core::_ops::OpDecl { } } impl op_async_result_impl { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call( x: i32, ) -> Result>, AnyError> { diff --git a/ops/op2/test_cases/async/async_result_smi.out b/ops/op2/test_cases/async/async_result_smi.out index 17285ceed..a7c072022 100644 --- a/ops/op2/test_cases/async/async_result_smi.out +++ b/ops/op2/test_cases/async/async_result_smi.out @@ -145,7 +145,7 @@ pub const fn op_async() -> ::deno_core::_ops::OpDecl { } } impl op_async { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call(rid: ResourceId) -> std::io::Result { Ok(rid as _) } diff --git a/ops/op2/test_cases/async/async_stack_trace.out b/ops/op2/test_cases/async/async_stack_trace.out index 4c05fd3f3..f2a47df89 100644 --- a/ops/op2/test_cases/async/async_stack_trace.out +++ b/ops/op2/test_cases/async/async_stack_trace.out @@ -111,7 +111,7 @@ pub const fn op_async_stack_trace() -> ::deno_core::_ops::OpDecl { } } impl op_async_stack_trace { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call() {} } ::DECL diff --git a/ops/op2/test_cases/async/async_v8_global.out b/ops/op2/test_cases/async/async_v8_global.out index f35e48664..d8f695736 100644 --- a/ops/op2/test_cases/async/async_v8_global.out +++ b/ops/op2/test_cases/async/async_v8_global.out @@ -115,7 +115,7 @@ pub const fn op_async_v8_global() -> ::deno_core::_ops::OpDecl { } } impl op_async_v8_global { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call(_s: v8::Global) {} } ::DECL diff --git a/ops/op2/test_cases/async/async_void.out b/ops/op2/test_cases/async/async_void.out index 4f7028bdb..df3ac7ac5 100644 --- a/ops/op2/test_cases/async/async_void.out +++ b/ops/op2/test_cases/async/async_void.out @@ -96,7 +96,7 @@ pub const fn op_async() -> ::deno_core::_ops::OpDecl { } } impl op_async { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub async fn call() {} } ::DECL diff --git a/ops/op2/test_cases/sync/add.out b/ops/op2/test_cases/sync/add.out index 15f87d058..82a2d301c 100644 --- a/ops/op2/test_cases/sync/add.out +++ b/ops/op2/test_cases/sync/add.out @@ -209,7 +209,7 @@ const fn op_add() -> ::deno_core::_ops::OpDecl { } } impl op_add { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(a: u32, b: u32) -> u32 { a + b } diff --git a/ops/op2/test_cases/sync/add_options.out b/ops/op2/test_cases/sync/add_options.out index 0e3b76710..908e3f9e1 100644 --- a/ops/op2/test_cases/sync/add_options.out +++ b/ops/op2/test_cases/sync/add_options.out @@ -115,7 +115,7 @@ pub const fn op_test_add_option() -> ::deno_core::_ops::OpDecl { } } impl op_test_add_option { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(a: u32, b: Option) -> u32 { a + b.unwrap_or(100) } diff --git a/ops/op2/test_cases/sync/bigint.out b/ops/op2/test_cases/sync/bigint.out index e1b1fb167..8a173bb79 100644 --- a/ops/op2/test_cases/sync/bigint.out +++ b/ops/op2/test_cases/sync/bigint.out @@ -136,7 +136,7 @@ pub const fn op_bigint() -> ::deno_core::_ops::OpDecl { } } impl op_bigint { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> u64 { 0 } diff --git a/ops/op2/test_cases/sync/bool.out b/ops/op2/test_cases/sync/bool.out index d43d92b3e..8bbcc366b 100644 --- a/ops/op2/test_cases/sync/bool.out +++ b/ops/op2/test_cases/sync/bool.out @@ -151,7 +151,7 @@ pub const fn op_bool() -> ::deno_core::_ops::OpDecl { } } impl op_bool { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(arg: bool) -> bool { arg } diff --git a/ops/op2/test_cases/sync/bool_result.out b/ops/op2/test_cases/sync/bool_result.out index dc4332280..5d8f34110 100644 --- a/ops/op2/test_cases/sync/bool_result.out +++ b/ops/op2/test_cases/sync/bool_result.out @@ -202,7 +202,7 @@ pub const fn op_bool() -> ::deno_core::_ops::OpDecl { } } impl op_bool { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(arg: bool) -> Result { Ok(arg) } diff --git a/ops/op2/test_cases/sync/buffers.out b/ops/op2/test_cases/sync/buffers.out index 8fc0153c8..74079d4a1 100644 --- a/ops/op2/test_cases/sync/buffers.out +++ b/ops/op2/test_cases/sync/buffers.out @@ -275,7 +275,7 @@ const fn op_buffers() -> ::deno_core::_ops::OpDecl { } } impl op_buffers { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_a: &[u8], _b: &mut [u8], _c: *const u8, _d: *mut u8) {} } ::DECL @@ -558,7 +558,7 @@ const fn op_buffers_32() -> ::deno_core::_ops::OpDecl { } } impl op_buffers_32 { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_a: &[u32], _b: &mut [u32], _c: *const u32, _d: *mut u32) {} } ::DECL @@ -706,7 +706,7 @@ const fn op_buffers_option() -> ::deno_core::_ops::OpDecl { } } impl op_buffers_option { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_a: Option<&[u8]>, _b: Option) {} } ::DECL diff --git a/ops/op2/test_cases/sync/buffers_copy.out b/ops/op2/test_cases/sync/buffers_copy.out index 49190ace3..e4e8e940d 100644 --- a/ops/op2/test_cases/sync/buffers_copy.out +++ b/ops/op2/test_cases/sync/buffers_copy.out @@ -231,7 +231,7 @@ const fn op_buffers() -> ::deno_core::_ops::OpDecl { } } impl op_buffers { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_a: Vec, _b: Box<[u8]>, _c: bytes::Bytes) {} } ::DECL @@ -442,7 +442,7 @@ const fn op_buffers_32() -> ::deno_core::_ops::OpDecl { } } impl op_buffers_32 { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_a: Vec, _b: Box<[u32]>) {} } ::DECL diff --git a/ops/op2/test_cases/sync/buffers_out.out b/ops/op2/test_cases/sync/buffers_out.out index 8f04e7e7e..bbb593b1f 100644 --- a/ops/op2/test_cases/sync/buffers_out.out +++ b/ops/op2/test_cases/sync/buffers_out.out @@ -113,7 +113,7 @@ const fn op_buffers() -> ::deno_core::_ops::OpDecl { } } impl op_buffers { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(buffer: JsBuffer) -> JsBuffer { buffer } @@ -246,7 +246,7 @@ const fn op_buffers_option() -> ::deno_core::_ops::OpDecl { } } impl op_buffers_option { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(buffer: Option) -> Option { buffer } @@ -365,7 +365,7 @@ const fn op_arraybuffers() -> ::deno_core::_ops::OpDecl { } } impl op_arraybuffers { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(buffer: JsBuffer) -> JsBuffer { buffer } diff --git a/ops/op2/test_cases/sync/cfg.out b/ops/op2/test_cases/sync/cfg.out index 6ee6e06ac..d53748048 100644 --- a/ops/op2/test_cases/sync/cfg.out +++ b/ops/op2/test_cases/sync/cfg.out @@ -137,7 +137,7 @@ pub const fn op_maybe_windows() -> ::deno_core::_ops::OpDecl { } } impl op_maybe_windows { - #[inline(always)] + #[allow(clippy::too_many_arguments)] /// This is a doc comment. #[cfg(windows)] pub fn call() -> () {} @@ -284,7 +284,7 @@ pub const fn op_maybe_windows() -> ::deno_core::_ops::OpDecl { } } impl op_maybe_windows { - #[inline(always)] + #[allow(clippy::too_many_arguments)] /// This is a doc comment. #[cfg(not(windows))] pub fn call() -> () {} diff --git a/ops/op2/test_cases/sync/clippy_allow.out b/ops/op2/test_cases/sync/clippy_allow.out index 63640a431..800af74ab 100644 --- a/ops/op2/test_cases/sync/clippy_allow.out +++ b/ops/op2/test_cases/sync/clippy_allow.out @@ -137,7 +137,7 @@ pub const fn op_extra_annotation() -> ::deno_core::_ops::OpDecl { } } impl op_extra_annotation { - #[inline(always)] + #[allow(clippy::too_many_arguments)] /// This is a doc comment. #[allow(clippy::some_annotation)] pub fn call() -> () {} @@ -282,7 +282,7 @@ pub const fn op_clippy_internal() -> ::deno_core::_ops::OpDecl { } } impl op_clippy_internal { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> () { { #![allow(clippy::await_holding_refcell_ref)] } } diff --git a/ops/op2/test_cases/sync/cppgc_resource.out b/ops/op2/test_cases/sync/cppgc_resource.out index c3f2c3305..b1d240874 100644 --- a/ops/op2/test_cases/sync/cppgc_resource.out +++ b/ops/op2/test_cases/sync/cppgc_resource.out @@ -197,7 +197,7 @@ const fn op_cppgc_object() -> ::deno_core::_ops::OpDecl { } } impl op_cppgc_object { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_resource: &Wrap) {} } ::DECL @@ -410,7 +410,7 @@ const fn op_option_cppgc_object() -> ::deno_core::_ops::OpDecl { } } impl op_option_cppgc_object { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_resource: Option<&Wrap>) {} } ::DECL @@ -502,7 +502,7 @@ const fn op_make_cppgc_object() -> ::deno_core::_ops::OpDecl { } } impl op_make_cppgc_object { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call() -> Wrap { Wrap } @@ -709,7 +709,7 @@ const fn op_use_cppgc_object() -> ::deno_core::_ops::OpDecl { } } impl op_use_cppgc_object { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_wrap: &Wrap) {} } ::DECL @@ -804,7 +804,7 @@ const fn op_make_cppgc_object_option() -> ::deno_core::_ops::OpDecl { } } impl op_make_cppgc_object_option { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call() -> Option { Some(Wrap) } @@ -1011,7 +1011,7 @@ const fn op_use_cppgc_object_option() -> ::deno_core::_ops::OpDecl { } } impl op_use_cppgc_object_option { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_wrap: &Wrap) {} } ::DECL diff --git a/ops/op2/test_cases/sync/doc_comment.out b/ops/op2/test_cases/sync/doc_comment.out index b43365f08..55c1aca86 100644 --- a/ops/op2/test_cases/sync/doc_comment.out +++ b/ops/op2/test_cases/sync/doc_comment.out @@ -136,7 +136,7 @@ pub const fn op_has_doc_comment() -> ::deno_core::_ops::OpDecl { } } impl op_has_doc_comment { - #[inline(always)] + #[allow(clippy::too_many_arguments)] /// This is a doc comment. pub fn call() -> () {} } diff --git a/ops/op2/test_cases/sync/fast_alternative.out b/ops/op2/test_cases/sync/fast_alternative.out index 56ae00199..6390413fb 100644 --- a/ops/op2/test_cases/sync/fast_alternative.out +++ b/ops/op2/test_cases/sync/fast_alternative.out @@ -108,7 +108,7 @@ const fn op_slow() -> ::deno_core::_ops::OpDecl { } } impl op_slow { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_scope: &v8::HandleScope, a: u32, b: u32) -> u32 { a + b } @@ -327,7 +327,7 @@ const fn op_fast() -> ::deno_core::_ops::OpDecl { } } impl op_fast { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(a: u32, b: u32) -> u32 { a + b } @@ -445,7 +445,7 @@ const fn op_slow_generic() -> ::deno_core::_ops::OpDecl { } } impl op_slow_generic { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_scope: &v8::HandleScope, a: u32, b: u32) -> u32 { a + b } @@ -664,7 +664,7 @@ const fn op_fast_generic() -> ::deno_core::_ops::OpDecl { } } impl op_fast_generic { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(a: u32, b: u32) -> u32 { a + b } diff --git a/ops/op2/test_cases/sync/from_v8.out b/ops/op2/test_cases/sync/from_v8.out index 45d328dca..c036f4122 100644 --- a/ops/op2/test_cases/sync/from_v8.out +++ b/ops/op2/test_cases/sync/from_v8.out @@ -95,7 +95,7 @@ pub const fn op_from_v8_arg() -> ::deno_core::_ops::OpDecl { } } impl op_from_v8_arg { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(foo: Foo) { let _ = foo; } diff --git a/ops/op2/test_cases/sync/generics.out b/ops/op2/test_cases/sync/generics.out index 95e7a4325..ebfedb5ae 100644 --- a/ops/op2/test_cases/sync/generics.out +++ b/ops/op2/test_cases/sync/generics.out @@ -135,7 +135,7 @@ pub const fn op_generics() -> ::deno_core::_ops::OpDecl { } } impl op_generics { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() {} } as ::deno_core::_ops::Op>::DECL @@ -278,7 +278,7 @@ pub const fn op_generics_static() -> ::deno_core::_ops::OpDe } } impl op_generics_static { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() {} } as ::deno_core::_ops::Op>::DECL @@ -421,7 +421,7 @@ pub const fn op_generics_static_where() -> ::deno_core::_ops } } impl op_generics_static_where { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() where T: Trait + 'static, diff --git a/ops/op2/test_cases/sync/nofast.out b/ops/op2/test_cases/sync/nofast.out index 98cdeaa50..592ac5c2e 100644 --- a/ops/op2/test_cases/sync/nofast.out +++ b/ops/op2/test_cases/sync/nofast.out @@ -108,7 +108,7 @@ const fn op_nofast() -> ::deno_core::_ops::OpDecl { } } impl op_nofast { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(a: u32, b: u32) -> u32 { a + b } diff --git a/ops/op2/test_cases/sync/object_wrap.out b/ops/op2/test_cases/sync/object_wrap.out index dc5b2c883..77c2e28df 100644 --- a/ops/op2/test_cases/sync/object_wrap.out +++ b/ops/op2/test_cases/sync/object_wrap.out @@ -136,7 +136,7 @@ impl Foo { } } impl constructor { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(x: Option) -> Foo { Foo { x: Cell::new(x.unwrap_or_default()), @@ -247,7 +247,7 @@ impl Foo { fn call(&self) -> u32; } impl Callable for Foo { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(&self) -> u32 { self.x.get() } @@ -370,7 +370,7 @@ impl Foo { fn call(&self, x: u32); } impl Callable for Foo { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(&self, x: u32) { self.x.set(x); } @@ -513,7 +513,7 @@ impl Foo { fn call(&self, _v: u32); } impl Callable for Foo { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(&self, _v: u32) {} } ::DECL @@ -708,7 +708,7 @@ impl Foo { fn call(&self); } impl Callable for Foo { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(&self) {} } ::DECL @@ -818,7 +818,7 @@ impl Foo { fn call(&self, _args: Option<&v8::FunctionCallbackArguments>); } impl Callable for Foo { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(&self, _args: Option<&v8::FunctionCallbackArguments>) {} } ::DECL @@ -925,7 +925,7 @@ impl Foo { fn call(&self); } impl Callable for Foo { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(&self) {} } ::DECL @@ -1011,7 +1011,7 @@ impl Foo { } } impl __static_doThing { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call() {} } <__static_doThing as ::deno_core::_ops::Op>::DECL @@ -1118,7 +1118,7 @@ impl Foo { fn call(&self); } impl Callable for Foo { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(&self) {} } ::DECL diff --git a/ops/op2/test_cases/sync/op_state_attr.out b/ops/op2/test_cases/sync/op_state_attr.out index 5ef3451b2..e5c0cd592 100644 --- a/ops/op2/test_cases/sync/op_state_attr.out +++ b/ops/op2/test_cases/sync/op_state_attr.out @@ -169,7 +169,7 @@ const fn op_state_rc() -> ::deno_core::_ops::OpDecl { } } impl op_state_rc { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_arg: &Something, _arg_opt: Option<&Something>) {} } ::DECL diff --git a/ops/op2/test_cases/sync/op_state_rc.out b/ops/op2/test_cases/sync/op_state_rc.out index 77f5d2fe9..a7bca96de 100644 --- a/ops/op2/test_cases/sync/op_state_rc.out +++ b/ops/op2/test_cases/sync/op_state_rc.out @@ -163,7 +163,7 @@ const fn op_state_rc() -> ::deno_core::_ops::OpDecl { } } impl op_state_rc { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_state: Rc>) {} } ::DECL diff --git a/ops/op2/test_cases/sync/op_state_ref.out b/ops/op2/test_cases/sync/op_state_ref.out index b8335407c..d615e7ef3 100644 --- a/ops/op2/test_cases/sync/op_state_ref.out +++ b/ops/op2/test_cases/sync/op_state_ref.out @@ -163,7 +163,7 @@ const fn op_state_ref() -> ::deno_core::_ops::OpDecl { } } impl op_state_ref { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_state: &OpState) {} } ::DECL @@ -334,7 +334,7 @@ const fn op_state_mut() -> ::deno_core::_ops::OpDecl { } } impl op_state_mut { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_state: &mut OpState) {} } ::DECL @@ -447,7 +447,7 @@ const fn op_state_and_v8() -> ::deno_core::_ops::OpDecl { } } impl op_state_and_v8 { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_state: &mut OpState, _callback: v8::Global) {} } ::DECL @@ -665,7 +665,7 @@ const fn op_state_and_v8_local() -> ::deno_core::_ops::OpDecl { } } impl op_state_and_v8_local { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_state: &mut OpState, _callback: v8::Local) {} } ::DECL diff --git a/ops/op2/test_cases/sync/result_external.out b/ops/op2/test_cases/sync/result_external.out index be160bdd1..6238211b3 100644 --- a/ops/op2/test_cases/sync/result_external.out +++ b/ops/op2/test_cases/sync/result_external.out @@ -187,7 +187,7 @@ pub const fn op_external_with_result() -> ::deno_core::_ops::OpDecl { } } impl op_external_with_result { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> Result<*mut std::ffi::c_void, AnyError> { Ok(0 as _) } diff --git a/ops/op2/test_cases/sync/result_primitive.out b/ops/op2/test_cases/sync/result_primitive.out index 17c4716bf..e6ba48113 100644 --- a/ops/op2/test_cases/sync/result_primitive.out +++ b/ops/op2/test_cases/sync/result_primitive.out @@ -193,7 +193,7 @@ pub const fn op_u32_with_result() -> ::deno_core::_ops::OpDecl { } } impl op_u32_with_result { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> Result { Ok(0) } diff --git a/ops/op2/test_cases/sync/result_scope.out b/ops/op2/test_cases/sync/result_scope.out index 1b942e603..6798b0fa1 100644 --- a/ops/op2/test_cases/sync/result_scope.out +++ b/ops/op2/test_cases/sync/result_scope.out @@ -194,7 +194,7 @@ pub const fn op_void_with_result() -> ::deno_core::_ops::OpDecl { } } impl op_void_with_result { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(_scope: &mut v8::HandleScope) -> Result<(), AnyError> { Ok(()) } diff --git a/ops/op2/test_cases/sync/result_void.out b/ops/op2/test_cases/sync/result_void.out index 14fe66e62..0e837ff4b 100644 --- a/ops/op2/test_cases/sync/result_void.out +++ b/ops/op2/test_cases/sync/result_void.out @@ -185,7 +185,7 @@ pub const fn op_void_with_result() -> ::deno_core::_ops::OpDecl { } } impl op_void_with_result { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> std::io::Result<()> { Ok(()) } diff --git a/ops/op2/test_cases/sync/serde_v8.out b/ops/op2/test_cases/sync/serde_v8.out index bbc9564d2..5b1a5e542 100644 --- a/ops/op2/test_cases/sync/serde_v8.out +++ b/ops/op2/test_cases/sync/serde_v8.out @@ -113,7 +113,7 @@ pub const fn op_serde_v8() -> ::deno_core::_ops::OpDecl { } } impl op_serde_v8 { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(_input: Input) -> Output { Output {} } diff --git a/ops/op2/test_cases/sync/smi.out b/ops/op2/test_cases/sync/smi.out index cbfb1e7a0..ca2697ed1 100644 --- a/ops/op2/test_cases/sync/smi.out +++ b/ops/op2/test_cases/sync/smi.out @@ -269,7 +269,7 @@ const fn op_smi_unsigned_return() -> ::deno_core::_ops::OpDecl { } } impl op_smi_unsigned_return { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(a: Int16, b: Int32, c: Uint16, d: Uint32) -> Uint32 { a as Uint32 + b as Uint32 + c as Uint32 + d as Uint32 } @@ -548,7 +548,7 @@ const fn op_smi_signed_return() -> ::deno_core::_ops::OpDecl { } } impl op_smi_signed_return { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(a: Int16, b: Int32, c: Uint16, d: Uint32) -> Int32 { a as Int32 + b as Int32 + c as Int32 + d as Int32 } @@ -659,7 +659,7 @@ const fn op_smi_option() -> ::deno_core::_ops::OpDecl { } } impl op_smi_option { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(a: Option) -> Option { a } diff --git a/ops/op2/test_cases/sync/stack_trace.out b/ops/op2/test_cases/sync/stack_trace.out index 76983c681..05a028d51 100644 --- a/ops/op2/test_cases/sync/stack_trace.out +++ b/ops/op2/test_cases/sync/stack_trace.out @@ -188,7 +188,7 @@ const fn op_stack_trace() -> ::deno_core::_ops::OpDecl { } } impl op_stack_trace { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call() {} } ::DECL diff --git a/ops/op2/test_cases/sync/stack_trace_scope.out b/ops/op2/test_cases/sync/stack_trace_scope.out index 078d788bf..5dbea7c14 100644 --- a/ops/op2/test_cases/sync/stack_trace_scope.out +++ b/ops/op2/test_cases/sync/stack_trace_scope.out @@ -205,7 +205,7 @@ const fn op_stack_trace() -> ::deno_core::_ops::OpDecl { } } impl op_stack_trace { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(_: String) {} } ::DECL diff --git a/ops/op2/test_cases/sync/string_cow.out b/ops/op2/test_cases/sync/string_cow.out index 87d40c551..3c346c638 100644 --- a/ops/op2/test_cases/sync/string_cow.out +++ b/ops/op2/test_cases/sync/string_cow.out @@ -188,7 +188,7 @@ const fn op_string_cow() -> ::deno_core::_ops::OpDecl { } } impl op_string_cow { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(s: Cow) -> u32 { s.len() as _ } diff --git a/ops/op2/test_cases/sync/string_onebyte.out b/ops/op2/test_cases/sync/string_onebyte.out index a74f7d50f..4337b4177 100644 --- a/ops/op2/test_cases/sync/string_onebyte.out +++ b/ops/op2/test_cases/sync/string_onebyte.out @@ -182,7 +182,7 @@ const fn op_string_onebyte() -> ::deno_core::_ops::OpDecl { } } impl op_string_onebyte { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(s: Cow<[u8]>) -> u32 { s.len() as _ } diff --git a/ops/op2/test_cases/sync/string_option_return.out b/ops/op2/test_cases/sync/string_option_return.out index 99306812a..3a21c1d4a 100644 --- a/ops/op2/test_cases/sync/string_option_return.out +++ b/ops/op2/test_cases/sync/string_option_return.out @@ -99,7 +99,7 @@ pub const fn op_string_return() -> ::deno_core::_ops::OpDecl { } } impl op_string_return { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(s: Option) -> Option { s } diff --git a/ops/op2/test_cases/sync/string_owned.out b/ops/op2/test_cases/sync/string_owned.out index 5d3a8214e..8d1bfa717 100644 --- a/ops/op2/test_cases/sync/string_owned.out +++ b/ops/op2/test_cases/sync/string_owned.out @@ -166,7 +166,7 @@ const fn op_string_owned() -> ::deno_core::_ops::OpDecl { } } impl op_string_owned { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(s: String) -> u32 { s.len() as _ } diff --git a/ops/op2/test_cases/sync/string_ref.out b/ops/op2/test_cases/sync/string_ref.out index 4c6e741ac..168c47042 100644 --- a/ops/op2/test_cases/sync/string_ref.out +++ b/ops/op2/test_cases/sync/string_ref.out @@ -188,7 +188,7 @@ const fn op_string_owned() -> ::deno_core::_ops::OpDecl { } } impl op_string_owned { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(s: &str) -> u32 { s.len() as _ } diff --git a/ops/op2/test_cases/sync/string_return.out b/ops/op2/test_cases/sync/string_return.out index d5e3713a6..9e5c8f993 100644 --- a/ops/op2/test_cases/sync/string_return.out +++ b/ops/op2/test_cases/sync/string_return.out @@ -88,7 +88,7 @@ pub const fn op_string_return() -> ::deno_core::_ops::OpDecl { } } impl op_string_return { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> String { "".into() } @@ -186,7 +186,7 @@ pub const fn op_string_return_ref() -> ::deno_core::_ops::OpDecl { } } impl op_string_return_ref { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> &'static str { "" } @@ -284,7 +284,7 @@ pub const fn op_string_return_cow() -> ::deno_core::_ops::OpDecl { } } impl op_string_return_cow { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call<'a>() -> Cow<'a, str> { "".into() } diff --git a/ops/op2/test_cases/sync/to_v8.out b/ops/op2/test_cases/sync/to_v8.out index df5b81981..860fec805 100644 --- a/ops/op2/test_cases/sync/to_v8.out +++ b/ops/op2/test_cases/sync/to_v8.out @@ -94,7 +94,7 @@ pub const fn op_to_v8_return() -> ::deno_core::_ops::OpDecl { } } impl op_to_v8_return { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call() -> Foo { Foo } diff --git a/ops/op2/test_cases/sync/v8_global.out b/ops/op2/test_cases/sync/v8_global.out index 1aa3f2bce..602601dd2 100644 --- a/ops/op2/test_cases/sync/v8_global.out +++ b/ops/op2/test_cases/sync/v8_global.out @@ -97,7 +97,7 @@ pub const fn op_global() -> ::deno_core::_ops::OpDecl { } } impl op_global { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call(g: v8::Global) -> v8::Global { g } diff --git a/ops/op2/test_cases/sync/v8_handlescope.out b/ops/op2/test_cases/sync/v8_handlescope.out index 139e9b73f..3c43265c3 100644 --- a/ops/op2/test_cases/sync/v8_handlescope.out +++ b/ops/op2/test_cases/sync/v8_handlescope.out @@ -97,7 +97,7 @@ const fn op_handlescope() -> ::deno_core::_ops::OpDecl { } } impl op_handlescope { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call<'a>( _scope: &v8::HandleScope<'a>, _str2: v8::Local, diff --git a/ops/op2/test_cases/sync/v8_lifetime.out b/ops/op2/test_cases/sync/v8_lifetime.out index a1d6ab6f8..41909336e 100644 --- a/ops/op2/test_cases/sync/v8_lifetime.out +++ b/ops/op2/test_cases/sync/v8_lifetime.out @@ -96,7 +96,7 @@ pub const fn op_v8_lifetime() -> ::deno_core::_ops::OpDecl { } } impl op_v8_lifetime { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call<'s>(_s: v8::Local<'s, v8::String>) -> v8::Local<'s, v8::String> { unimplemented!() } diff --git a/ops/op2/test_cases/sync/v8_ref_option.out b/ops/op2/test_cases/sync/v8_ref_option.out index 6a3d0f612..e63d845d0 100644 --- a/ops/op2/test_cases/sync/v8_ref_option.out +++ b/ops/op2/test_cases/sync/v8_ref_option.out @@ -248,7 +248,7 @@ pub const fn op_v8_lifetime() -> ::deno_core::_ops::OpDecl { } } impl op_v8_lifetime { - #[inline(always)] + #[allow(clippy::too_many_arguments)] pub fn call<'s>(_s: Option<&v8::String>, _s2: Option<&v8::String>) {} } ::DECL diff --git a/ops/op2/test_cases/sync/v8_string.out b/ops/op2/test_cases/sync/v8_string.out index c9551a1b8..4e3f93b8f 100644 --- a/ops/op2/test_cases/sync/v8_string.out +++ b/ops/op2/test_cases/sync/v8_string.out @@ -112,7 +112,7 @@ const fn op_v8_string() -> ::deno_core::_ops::OpDecl { } } impl op_v8_string { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call<'a>( _str1: &v8::String, _str2: v8::Local, diff --git a/ops/op2/test_cases/sync/webidl.out b/ops/op2/test_cases/sync/webidl.out index 8d06ddb47..525b3d58b 100644 --- a/ops/op2/test_cases/sync/webidl.out +++ b/ops/op2/test_cases/sync/webidl.out @@ -121,7 +121,7 @@ const fn op_webidl() -> ::deno_core::_ops::OpDecl { } } impl op_webidl { - #[inline(always)] + #[allow(clippy::too_many_arguments)] fn call(s: String, _n: u32) -> u32 { s.len() as _ }