Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document tini #299

Open
benatkin opened this issue Jun 12, 2023 · 3 comments
Open

Document tini #299

benatkin opened this issue Jun 12, 2023 · 3 comments

Comments

@benatkin
Copy link

Unlike the official images for python and node, Deno's docker images bundle tini. This seems to be a good idea, but it doesn't say in the README why it uses tini and others don't. I think it's because other runtimes let the devs deal with the mess that having no init and having no signal handling creates, while Deno helps by adding tini.

Perhaps Deno could make it so tini (or docker run --init) is presented less as the only way to run it, because the signal API was made stable (February 17, 2022) after tini was added to the Dockerfile(Aug 23, 2021).

@dojyorin
Copy link

I also agree with using Docker built-in tini.
I think contents of container image should be simple.

@benatkin
Copy link
Author

Also the Docker image from which it pulls tini, buildpack-deps, doesn't mention tini in its README

@dojyorin
Copy link

dojyorin commented Nov 7, 2023

Although experimental I created simple and clean dockerfile for alpine and distroless.
Synced daily with original deno and automatically pushed to DockerHub.
If works fine, I consider making pull request to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants