Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: blockquote text not parsed as markdown #2699

Closed
mackieburgess opened this issue Oct 10, 2024 · 3 comments
Closed

Docs: blockquote text not parsed as markdown #2699

mackieburgess opened this issue Oct 10, 2024 · 3 comments

Comments

@mackieburgess
Copy link
Contributor

👋

The text inside blockquotes isn't being parsed as markdown: this means that – in mild instances – text which should be rendered as a codespan is instead displaying with backticks, and – in severe instances – codespans containing HTML are rendering as actual HTML, instead of being escaped (examples of both below).

Will put in a PR imminently :)

Screenshot 2024-10-10 at 13 41 24 Screenshot 2024-10-10 at 13 41 39
@mackieburgess mackieburgess mentioned this issue Oct 10, 2024
Merged
marvinhagemeister pushed a commit that referenced this issue Oct 10, 2024
@mackieburgess
docs: fix blockquote text not parsed as markdown (#2700)
8752dba 
See issue #2699.

Blockquote text now renders correctly as markdown.

<img width="718" alt="Screenshot 2024-10-10 at 13 42 26"
src="https://github.com/user-attachments/assets/d39dc04e-a408-4f34-a632-881578856896">

<img width="729" alt="Screenshot 2024-10-10 at 13 42 47"
src="https://github.com/user-attachments/assets/e2686cd0-b39c-402d-b460-6f680d5e6d04">
@monooleate
Copy link

monooleate commented Oct 10, 2024 •
edited
Loading

After your recent commit, the info|warn|tip tags are still not functioning as expected. It seems that with your changes in markdown.ts, these tags will work if you modify the ADMISSION_REG constant by removing the "<" p ">" tag, like so: /^[(info|warn|tip)]:\s/. This adjustment should resolve the issue.

@mackieburgess
Copy link
Contributor Author

@monooleate ah yes, I can put this in as a separate PR.

@mackieburgess mackieburgess mentioned this issue Oct 10, 2024
Merged
marvinhagemeister pushed a commit that referenced this issue Oct 10, 2024
@mackieburgess
docs: fix admonition regular expression (#2702)
dd55558 
From #2699, Co-authored by @monooleate

Added `margin-bottom` to better visually align icon with title.
@marvinhagemeister
Copy link
Collaborator

Resolved with #2702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marvinhagemeister @monooleate @mackieburgess