Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM specifier support in Fresh #978

Closed
lucacasonato opened this issue Jan 10, 2023 · 6 comments
Closed

NPM specifier support in Fresh #978

lucacasonato opened this issue Jan 10, 2023 · 6 comments
Labels
feat New feature or request upstream The issue is with an upstream dependency.

Comments

@lucacasonato
Copy link
Member

To support NPM specifiers in Fresh, we need to support them in esbuild_deno_loader first: lucacasonato/esbuild_deno_loader#29

Also Deno Deploy support is still pending.
@lucacasonato lucacasonato added the feat New feature or request label Jan 10, 2023
@lucacasonato lucacasonato pinned this issue Jan 10, 2023
This was referenced Jan 10, 2023
Closed
Closed
Closed
@codesculpture
Copy link
Contributor

lucacasonato/esbuild_deno_loader#33

@maciejkulinski
Copy link

lucacasonato/esbuild_deno_loader#40

@hashrock hashrock mentioned this issue Mar 28, 2023
Closed
@lucacasonato lucacasonato mentioned this issue Jun 3, 2023
Merged
lucacasonato added a commit that referenced this issue Jun 6, 2023
@lucacasonato
feat: limited npm: specifier support (#1245)
bb48f7b 
This commit adds limited support for `npm:` specifiers. Right now,
`npm:` specifiers are unsupported on Deno Deploy.

Towards #978
@fro-profesional
Copy link

https://deno.com/blog/npm-on-deno-deploy 🔥

@guy-borderless
Copy link

should this be closed?

@fro-profesional
Copy link

fro-profesional commented Oct 5, 2023 •
edited
Loading

I think the new release includes this fix: #1841 so maybe after the new release ¿?

@marvinhagemeister
Copy link
Collaborator

Basic npm: support works in Fresh, but to make peer dependencies work, we're blocked by denoland/deno#20868 . Leaving the issue open until that is resolved.

@marvinhagemeister marvinhagemeister added the upstream The issue is with an upstream dependency. label Nov 28, 2023
@fazil47 fazil47 mentioned this issue Mar 15, 2024
Open
@marvinhagemeister marvinhagemeister unpinned this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request upstream The issue is with an upstream dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@marvinhagemeister @lucacasonato @maciejkulinski @codesculpture @fro-profesional @guy-borderless