All committers have signed the CLA.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (9b86f0f) to head (488f223).

@@           Coverage Diff           @@
##             main    #6318   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files         547      547           
  Lines       41731    41755   +24     
  Branches     6325     6331    +6     
=======================================
+ Hits        40212    40238   +26     
+ Misses       1478     1476    -2     
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks for the PR. This looks much better than the current state!

However if I filled the first 2 lines and then deleted the entire 2nd line, then the initial prompt part was duplicated again.. Could you take a look at this point as well?

(I guess we can use 'Cursor Control' codes to remove the entire prompt + masks https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797#cursor-controls)

Thanks for the PR. This looks much better than the current state!

However if I filled the first 2 lines and then deleted the entire 2nd line, then the initial prompt part was duplicated again.. Could you take a look at this point as well?

(I guess we can use 'Cursor Control' codes to remove the entire prompt + masks https://gist.github.com/fnky/458719343aabd01cfb17a3a4f7296797#cursor-controls)

Absolutely!

Two thoughts:

1. Would it be beneficial to create a "cliWindow" utility that sets a height/width and handles overflow? Seems like it could be useful more generally. I think it may be necessary to achieve this, because
2. How do we handle screen resizes? We have to know the former width so we can figure out how many lines to move back and replace. (This is more of a "I think," as I haven't played around yet)

edit: While I think a CliWindow utility class may be helpful, it's not strictly necessary to close this ticket.

@kt3k I believe your issue is addressed. I've updated the description to include a screen recording of the current implementation.

There's still an issue where resizing the screen after prompting causes undesirable behavior. In order to fix this, we need to keep track of the console size and check it before writing anything to the terminal. Is calling Deno.consoleSize() an expensive operation, or is it safe to do on each character press?

An example of what happens when resizing a terminal window: