Leaf 4486 - prevent user name recycle #2624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jampaul3
requested review from
mgaoVA,
Pelentan,
aerinkayne,
pete-nerantzinis,
shaneodd and
nk2136
as code owners
Pelentan
previously approved these changes
Dec 18, 2024
aerinkayne
previously approved these changes
Dec 20, 2024
shaneodd
approved these changes
Dec 27, 2024
Pelentan
approved these changes
Dec 31, 2024
aerinkayne
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A way was needed to prevent Active Directory userNames from being recycled and showing data to the wrong person.
Potential Impact:
Currently there are userNames that have already been recycled. These will get missed and need to be done manually when they come up.
Disabling a user one at a time will use the same process but re-enabling them needs to be programmed yet.
Testing:
This will need to be done on staging. It is possible to set up local to do this I think but it is not currently done. Staging should be set and ready to do this.
To test just run the refreshOrgchartEmployees.php. All instances of userNames in all tables that store the userName in both the orgchart and any portals for that orgchart should be updated to the new format. disabled_ts_userName