-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DisabilityMaxRating client, configuration, and tests with get_ratings update #20483
Conversation
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/disability_max_rating/client_spec.rb |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/lib/disability_max_rating/client_spec.rb |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/support/vcr_cassettes/disability_max_rating/max_ratings_multiple.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Except, can you update your spec file changes to mock the new flipper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor nits/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
Summary
disability_526_max_cfi_service_switch
feature flag to control the switch between the Virtual Regional Office (VRO) client and the new Max Ratings service for fetching disability max ratings.DisabilityMaxRating::Client
along with its configuration to interact with the Max Ratings service.get_ratings
method in theClaimFastTracking::MaxRatingAnnotator
has been updated to use the new client when the feature toggle is enabled and fallback to the VRO client when disabled.get_ratings
method and the new client.Related issue(s)
Testing done
DisabilityMaxRating::Client
correctly interacts with the Max Ratings service.What areas of the site does it impact?
Acceptance criteria