QA Design Feedback

[jquispe-oddball]

Compiling all the QA feedback from Friday 2/14 into one ticket:

1. Make adjustments to ARP header based on design updates #101461 (comment)
2. Refine content on POA Requests detail view #100987 (comment)
3. Update copy & remove alert components - POA Request List Page #100988 (comment)
4. Create processing banner and decision status tags #99756 (comment)

Summary of feedback
Header:

• hover state has an underline that is not part of figma
• rounded corners on hover
• focus stays after being selected (?)

Page title

• missing title element - Oren submitted pr with fix

Processing Banner

• too much spacing after date, use margin instead of <br>
• mobile, text needs to span full width, see screenshot

Tags

• Pending doesn't match figma

Copy

• "Relationship to veteran" should be "Relationship to Veteran"
• Formatting on phone number
• hint text color contrast issue - reach out to @seipeljl
• update ssn/va label

Tabs

• tabs have default :visited styling for links, remove to match figma (?)
• page re-renders on click, only re-render list. - this was discussed in eng chat, see comment for ticket update

Items not part of v0

Sort by

• "Request list does not include language indicating to the user the number of requests and the sort order. Even though we are punting the sort component and pagination till later, recommend telling the user what they are seeing.
  Examples
  Pending tab: “Showing 10 pending requests sorted by “Expiration date (nearest)”
  Processed tab: Showing 98 processed requests sorted by “Processed date (nearest)”

Footer

• padding issues at the bottom. Not part of v0.

[jquispe-oddball]

Hey @nihil2501 I remember discussing loaders during one of our eng chats.
Is there a ticket somewhere? I know we specifically talked about cleaning it up on the POA request list page. Instead of "loading" on the body of the page, the spinner would appear under the tabs. I don't think this is a blocker, more of a clean up ticket. Please let me know!
cc: @eheintzelman @candilemoine

[nihil2501]

Hey @nihil2501 I remember discussing loaders during one of our eng chats. Is there a ticket somewhere? I know we specifically talked about cleaning it up on the POA request list page. Instead of "loading" on the body of the page, the spinner would appear under the tabs. I don't think this is a blocker, more of a clean up ticket. Please let me know! cc: @eheintzelman @candilemoine

@candilemoine @jquispe-oddball To get this more typical behavior where only the search results area shows a loading spinner when the search query changes will take a little work. We will need a new ticket for this. We might be able to address it before pilot launch.

Right now, the app is designed to show a global spinner on any client-side navigation, and search query changes cause client-side navigations. This is a great starting point, but the global spinner is not great UX here. We talked about cleanly introducing this UX elaboration in an engineering sync a week or two ago and have some promising ideas—we should be able to pull this off in a clean way.

[jquispe-oddball]

cross linking update from @seipeljl on hint text contrast issue:
#100987 (comment)

[jquispe-oddball]

@eheintzelman phone formatting will be part of v1
@candilemoine can you work with @chumpy and create a ticket? Thanks