Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grouped updates didn't group gomod updates #7974

Closed
1 task done
wadey opened this issue Sep 5, 2023 · 2 comments
Closed
1 task done

grouped updates didn't group gomod updates #7974

wadey opened this issue Sep 5, 2023 · 2 comments
Assignees
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR L: go:modules Golang modules T: bug 🐞 Something isn't working

Comments

@wadey
Copy link

wadey commented Sep 5, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

gomod

Package manager version

No response

Language version

1.20

Manifest location and content before the Dependabot update

go.mod: https://github.com/slackhq/nebula/blob/06b480e17751eb5d719ec85cb34e1abd51280a64/go.mod

dependabot.yml content

https://github.com/slackhq/nebula/blob/06b480e17751eb5d719ec85cb34e1abd51280a64/.github/dependabot.yml

Updated dependency

What you expected to see, versus what you actually saw

These dependencies should have been grouped together. My dependabot config has the follow, so I expected them to be grouped with golang-x-dependencies:

version: 2
updates:
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      interval: "weekly"

  - package-ecosystem: "gomod"
    directory: "/"
    schedule:
      interval: "weekly"
    groups:
      golang-x-dependencies:
        patterns:
          - "golang.org/x/*"
      zx2c4-dependencies:
        patterns:
          - "golang.zx2c4.com/*"
      protobuf-dependencies:
        patterns:
          - "github.com/golang/protobuf"
          - "google.golang.org/protobuf"

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@wadey wadey added the T: bug 🐞 Something isn't working label Sep 5, 2023
@sglavoie
Copy link

sglavoie commented Sep 7, 2023

We experienced the same situation in a (private) project using npm with a different set of patterns (irrelevant context removed):

version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/"
    groups:
      dev-dependencies:
        patterns:
          - "*"
        update-types:
          - "minor"
          - "patch"

We expected to see something like Bump the dev-dependencies group with X updates and yet Dependabot opened multiple PRs that should have been grouped:

Bump core-js from 3.32.1 to 3.32.2
Bump @fluentui/react-components from 9.29.4 to 9.30.4
Bump javascript-obfuscator from 4.0.2 to 4.1.0

Edit: We closed all existing pull requests from Dependabot, re-committed dependabot.yml and then it worked. When navigating to https://github.com/{owner}/{repo}/network/updates (Insights > Dependency graph > Dependabot) and checking the results for the last scan, we can find in the update logs the keywords "Starting grouped update", which weren't present on the previous run that didn't group updates.

@jakecoffman jakecoffman added F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR L: go:modules Golang modules labels Sep 28, 2023
@jakecoffman
Copy link
Member

@wadey I checked the database and it didn't have a record of the groups in the dependabot.yml for slackhq/nebula, so I kicked off a resync job and now it's showing the groups.

@sglavoie Yes this sounds like the same problem since it was fixed by modifying dependabot.yml.

Usually a whitespace change to the dependabot.yml will fix it as well.

I think Dependabot's service somehow missed the message that the dependabot.yml was updated so the new groups weren't processed. I'm going to reference this in an internal tracking issue, we've been looking at making some improvements around this to prevent it from happening.

Thanks for the report!

@jakecoffman jakecoffman self-assigned this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR L: go:modules Golang modules T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants