Skip to content
This repository has been archived by the owner on Jan 12, 2021. It is now read-only.

I want to be able to include package_data without an extension #14

Open
jochenparm opened this issue Oct 19, 2020 · 3 comments
Open

I want to be able to include package_data without an extension #14

jochenparm opened this issue Oct 19, 2020 · 3 comments

Comments

@jochenparm
Copy link

I'm having an issue with including a couple of files that I explicitly mention in my pyproject.toml but that don't end up in the package_data list of the converted setup.py

After a lot of trial and error, I started looking into how dephell actually identifies the files to be included. It appears that you're making the assumption that files without an extension are to be ignored.

Would you consider adapting this behavior? As far as I know, it's not bad practice to allow for files without an extension to be packaged up.

# skip dirs, python files and files without extension

@jochenparm
Copy link
Author

Can someone give me some feedback? It's easy enough to create a PR that fixes this, but I suppose that there might be a reason that it was implemented like this initially?

@orsinium
Copy link
Member

Sure, feel free to contribute.

@jochenparm
Copy link
Author

@orsinium
Can you have a look at the PR and let me know if it needs additional work?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants