Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many water improvement ideas! #42

Open
pasithea2 opened this issue Jan 5, 2019 · 2 comments
Open

Many water improvement ideas! #42

pasithea2 opened this issue Jan 5, 2019 · 2 comments
Labels
currently impossible Feature request of something impossible, or an unfixable bug enhancement New feature or request

Comments

@pasithea2
Copy link

pasithea2 commented Jan 5, 2019

I was wondering if you could improve the water in these ways:
Smoother waves.
Water reflections?
Clearer water. (Mabel using colormap or lighting?)
Water has holes when falling (image)
c2771d0e-9480-4ecb-8f2b-9affd15caa53

@depressed-pho
Copy link
Owner

depressed-pho commented Jan 5, 2019

Please make separate issues next time :)

  • Smoother waves: Yes I want to do it but since it needs a normal mapping it is currently infeasible due to a vanilla bug MCPE-40059.
  • Water reflections: The true reflection is impossible because it needs separate render passes for non-water blocks and water. Sadly we can't alter the rendering pipeline unlike Java shaders. We could possibly do some kind of fake reflection like the one SEUS PE does (Add water waves and fake reflection #10).
  • Clearer water: We can indeed reduce the transparency of water, but we can not achieve a good looking water rendering just by that. In real life water has almost no color and has almost perfect transparency but you can still see water in a glass. Why? Because water in reality cause refraction. Java shaders do this but in Bedrock we can't because this also requires separate render passes and also access to surface normals.
  • Water has holes when falling: Man, that's a vanilla bug :D

@depressed-pho depressed-pho added enhancement New feature or request currently impossible Feature request of something impossible, or an unfixable bug labels Jan 5, 2019
@gio1135
Copy link

gio1135 commented Jan 18, 2019

I add a biomes_client that makes underwater clear every time I download this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
currently impossible Feature request of something impossible, or an unfixable bug enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants