Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Shader is broken on android #62

Open
MrAgentBlaze opened this issue Feb 10, 2019 · 4 comments
Open

The Shader is broken on android #62

MrAgentBlaze opened this issue Feb 10, 2019 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@MrAgentBlaze
Copy link

MrAgentBlaze commented Feb 10, 2019

The Shader works in my new Samsung Galaxy A5 android 6.0.1 but it looks broken . You can see the pic i sent to pho (you) in discord

@depressed-pho depressed-pho added bug Something isn't working help wanted Extra attention is needed labels Feb 13, 2019
@depressed-pho
Copy link
Owner

depressed-pho commented Feb 13, 2019

Yes I saw it. The sky shader is working flawlessly but the terrain is rendered completely black. I have no idea why that happens. Someone please shed some light.

@gio1135
Copy link

gio1135 commented Feb 14, 2019

It works perfectly fine for me. I'm using a Pixel 2 XL.

@gio1135
Copy link

gio1135 commented Feb 14, 2019

Yes I saw it. The sky shader is working flawlessly but the terrain is rendered completely black. I have no idea why that happens. Someone please shed some light.

I see what you did there. Here, let me do so /effect @s night_vision 10000 255 true.

@depressed-pho
Copy link
Owner

In that screenshot the far terrain (where far chunk fogs normally appear) has some random colors like yellow, green, and red. This smells like a tone mapping curve being incorrectly applied, possibly due to precision loss of floating point arithmetic. I'll see if it can ever happen in my code, but it's most likely a driver bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants