Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How and/or whether to integrate ensures -> ensure changes in rule description into Japanese translation #4682

Open
ma10 opened this issue Jan 28, 2025 · 3 comments

Comments

@ma10
Copy link
Contributor

ma10 commented Jan 28, 2025

I just noticed that in rule descriptions, "Ensures ..." has been replaced with "Ensure ...", as proposed in #4385.
I'm wondering if this should be integrated into Japanese translation as "確認します" -> "確認してください" (or any other way)
While I personally think this should be done as the same reason as given for English phrases in #4385, the current translation is considered as something sufficient to convey the intention.

I'm mentioning those whom I can remember that have contributed to this translation file below, please post your thought:
@kiyochika @shunito @ymrl

If people think the changes should be integrated, I'll make a PR.

@ymrl
Copy link
Contributor

ymrl commented Jan 28, 2025

I agree.
Current phrases "確認します" are unclear who is directed at. I think it will be one of the reasons why Japanese speakers have the impression that axe or accessibility is difficult.
If these are "確認してください", users who speak Japanese can recognize that they should do some actions about it by themselves.

@shunito
Copy link
Contributor

shunito commented Jan 28, 2025

LGTM!

ma10 added a commit to ma10/axe-core that referenced this issue Jan 30, 2025
@ma10
Copy link
Contributor Author

ma10 commented Jan 30, 2025

Ok, I added commits to bring in these changes to #4683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants