From 1e424a743b5a62bd58e381a24b61b7bbe6172fab Mon Sep 17 00:00:00 2001
From: jayson wang <jayson@laboys.org>
Date: Sat, 11 Nov 2023 00:03:52 +0800
Subject: [PATCH] code quality

---
 internal/view/pod.go | 36 +++++++++++++++++++++---------------
 1 file changed, 21 insertions(+), 15 deletions(-)

diff --git a/internal/view/pod.go b/internal/view/pod.go
index 72c0012e1c..98600b2384 100644
--- a/internal/view/pod.go
+++ b/internal/view/pod.go
@@ -487,33 +487,39 @@ func podIsRunning(f dao.Factory, path string) bool {
 	return re.Phase(po) == render.Running
 }
 
+var (
+	ErrNoOSInfoFound = errors.New("no os information available")
+)
+
 func getPodOS(f dao.Factory, fqn string) (string, error) {
 	po, err := fetchPod(f, fqn)
 	if err != nil {
 		return "", err
 	}
-	if podOS, ok := po.Spec.NodeSelector[osBetaSelector]; ok {
+	if podOS, ok := osFromSelector(po.Spec.NodeSelector); ok {
 		return podOS, nil
 	}
-	if podOS, ok := po.Spec.NodeSelector[osSelector]; ok {
-		return podOS, nil
+	if len(po.Spec.NodeName) == 0 {
+		return "", ErrNoOSInfoFound
 	}
 
-	if len(po.Spec.NodeName) != 0 {
-		node, err := dao.FetchNode(context.Background(), f, po.Spec.NodeName)
-		if err != nil {
-			return "", err
-		}
+	node, err := dao.FetchNode(context.Background(), f, po.Spec.NodeName)
+	if err != nil {
+		return "", err
+	}
+	if nodeOS, ok := osFromSelector(node.Labels); ok {
+		return nodeOS, nil
+	}
+	return "", ErrNoOSInfoFound
+}
 
-		if nodeOS, ok := node.Labels[osBetaSelector]; ok {
-			return nodeOS, nil
-		}
-		if nodeOS, ok := node.Labels[osSelector]; ok {
-			return nodeOS, nil
-		}
+func osFromSelector(m map[string]string) (string, bool) {
+	if osName, ok := m[osBetaSelector]; ok {
+		return osName, true
 	}
 
-	return "", fmt.Errorf("no os information available")
+	osName, ok := m[osSelector]
+	return osName, ok
 }
 
 func resourceSorters(t *Table) ui.KeyActions {