-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOT][Accumulators]maryia/bot-1980/feat: Adapt QS form as per new design #17016
[BOT][Accumulators]maryia/bot-1980/feat: Adapt QS form as per new design #17016
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Quality Gate passedIssues Measures |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-bot-1980.binary.sx/ |
...i/src/pages/bot-builder/quick-strategy/form-wrappers/upgraded-qs-v2/desktop-form-wrapper.tsx
Outdated
Show resolved
Hide resolved
...t-web-ui/src/pages/bot-builder/quick-strategy/form-wrappers/upgraded-qs-v2/strategy-list.tsx
Outdated
Show resolved
Hide resolved
fe28368
to
818f1ae
Compare
9a18de8
to
b924467
Compare
⏳ Generating Lighthouse report... |
2d1bbd7
into
deriv-com:feature/quick-strategy-redesign
…ign (#17016) (#17296) * feat: Adapt QS form as per new design * refactor: desktop form wrapper component * refactor: desktop form wrapper component(2) * fix: btn back on the desktop * refactor: add useCallback for renderContent * refactor: strategy list component * fix: test cases of quick strategy * refactor: change logic as per new configuration of QS * add Stepper component from Quill, install quill libraries, update the version * chore: add temp stepper.scss * chore: merge master, resolve conflicts(part2) * fix: UI Bugs while creating a quick strategy * chore: update package-lock file * fix: eslint issues * style: fix margin strategy-template-picker * fix: tablet version bugs and rtl * fix: search option and change the color * fix: tooltip text * Delete packages/bot-web-ui/package-lock.json * chore: remove server bot icons and parameters --------- Co-authored-by: maryia-matskevich-deriv <[email protected]>
Changes:
Acceptance criteria:
A search field will be provided to enable faster information retrieval.
If the user searches the trade type like accumulators - we show accumulators as a parent and all its groups with strategies like Martingale and so on.
if the user searches "Martingale" - we will show all parents/trade types like "Accumulators" and behind it "Martingale"
The 'Learn More' button, previously integrated into a switcher, will now be an icon button adjacent to the search field. Tapping on it will bring users to the Tutorial page.
Once the user searches for something on Quick Strategy search and clicks on the icon for the tutorial tab. What we do is redirect to the tutorial page, and show all related material from guidelines, videos, and content.
Users can filter strategies by trade type. The default setting for this page will display 'All'.
When the strategy dropdown is expanded, a list of available trade types for that specific strategy will be displayed.
Once users proceed to the last step, there will be 3 CTAs for desktop version.
“Run” - this primary CTA will start the bot. In case there is field that is not filled, tapping on the CTA will validate the field and return error.
“Load” - this secondary CTA is for the users that do not wish to start their bot yet. Clicking on this button will load the strategy to the workspace and users will be able to further edit using blockly and add custom parameters.
“Back” - tertiary CTA to go back to the previous step and we will save the previous state of the field except if they choose another strategy.
A stepper will be implemented in the desktop design to clearly guide users on their next steps. Will be implemented in
deriv-com/quill-ui
On mobile:
Once users proceed to the last step, there will be 2 CTAs for responsive version.
We will show only chips with 'options' since strategies with trade type accumulator and multiplier aren't ready. So, chips such as 'all', 'accumulator', and 'multiplier' will be hidden for now.
It will be changed once the task with accumulators and multipliers is completed.
Screenshots:
Please provide some screenshots of the change.