Niloofar/Fix signup redirection

[niloofar-deriv]

Changes:

Please provide a summary of the change.

We had this issue:

I tried to signup from staging-app.deriv.com, it redirects me to production instead of staging.

This is a fix for this issue.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Oct 22, 2024 7:48am

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: Niloofar/Fix signup redirection #17282
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-niloofar-deriv-fix-signup-redirection.binary.sx?qa_server=red.derivws.com&app_id=23848
  • Original: https://deriv-app-git-fork-niloofar-deriv-fix-signup-redirection.binary.sx
• App ID: 23848

Click here to copy & paste above information.

- **PR**: [https://github.com/deriv-com/deriv-app/pull/17282](https://github.com/deriv-com/deriv-app/pull/17282)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-niloofar-deriv-fix-signup-redirection.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-niloofar-deriv-fix-signup-redirection.binary.sx
- **App ID**: `23848`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	26
🟧 Accessibility	70
🟢 Best practices	92
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-niloofar-deriv-fix-signup-redirection.binary.sx/

[coveralls]

Pull Request Test Coverage Report for Build 11455290544

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
• 297 unchanged lines in 12 files lost coverage.
• Overall coverage increased (+0.05%) to 53.788%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/core/src/App/Components/Layout/Header/signup-button.jsx	1	2	50.0%

Files with Coverage Reduction	New Missed Lines	%
packages/trader/src/AppV2/Components/TradeParameters/Strike/strike.tsx	1	87.88%
packages/trader/src/AppV2/Components/ServiceErrorSheet/service-error-description.tsx	1	78.95%
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx	1	83.7%
packages/trader/src/AppV2/Components/TradeParameters/PayoutPerPoint/payout-per-point.tsx	1	87.88%
packages/trader/src/AppV2/Components/ServiceErrorSheet/service-error-sheet.tsx	2	92.47%
packages/trader/src/AppV2/Components/PurchaseButton/purchase-button.tsx	3	88.99%
packages/trader/src/AppV2/Components/TradeParameters/Stake/stake.tsx	7	87.61%
packages/trader/src/AppV2/Components/TradeParameters/Duration/duration.tsx	9	77.27%
packages/trader/src/AppV2/Containers/Trade/trade-types.tsx	10	83.33%
packages/core/src/Stores/contract-store.js	66	0.0%

Totals
Change from base Build 11439126147:	0.05%
Covered Lines:	35101
Relevant Lines:	60692

---

💛 - Coveralls

[amam-deriv]

what happen with NODE_ENV check?, is it not reliable?

[niloofar-deriv]

No @amam-deriv it's not working properly so I decided to replace it with the safer one 😁

[github-actions]

⏳ Generating Lighthouse report...