Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likhith/TRAH-4339]/incorporated check on mt5 to enable employment-&-tin #17309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Added condition to check if user has regulated MT5 account before enforcing employment status and tin rules

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 23, 2024 11:04am

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17309](https://github.com/deriv-com/deriv-app/pull/17309)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-trah-4339fix-ti-c87e1e.binary.sx?qa_server=red.derivws.com&app_id=31482
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-trah-4339fix-ti-c87e1e.binary.sx
- **App ID**: `31482`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-trah-4339fix-ti-c87e1e.binary.sx/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11478217155

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 53.723%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/account/src/Configs/user-profile-validation-config.ts 6 7 85.71%
packages/core/src/Stores/traders-hub-store.js 0 2 0.0%
Totals Coverage Status
Change from base Build 11475490690: 0.004%
Covered Lines: 35171
Relevant Lines: 60901

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants