-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some of the new definitions may be a bit too restrictive. #48
Comments
scsi or virtio-scsi? As you're creating a VM disk image (whether for proxmox or another hypervisor) I am not expecting scsi to used, only virtio-blk, virtio-scsi, or nvme (as there is no virtio equivalent of nvme). Firstly scsi will be far less performant than virtio-scso. Secondly why use scsi for a VM at all? If you want scsi then why not create a physical machine image, rather than a VM image?
Yeah originally generic was only intended for use by the "generic" cloud/physical/virtual types. I have since started extending it for other situations. I have some local code changes for this that I will push shortly.
I've made some changes to the proxmox definition file(s) but haven't pushed them yet. I'll add a note here when I have done so. What would be useful info is details of what are the default Proxmox settings used for created VMs in terms of console type (i.e. serial or normal), storage driver, etc. |
Yes, sorry, Though it does allow emulating others (It's just QEMU under the hood) and perhaps some configurations may use others or may have raw device pass through. Allowing people to always pick The default display for new vms is QEMU's "std" vga card but it also has options for a variety of other cards and/or serial. |
Hi. I've just merged a PR where I've rewritten a lot of the "generic" handling. I've also updated/tweaked the proxmox definitions files. So currently virtio-scsi is defaulted to as the type of device for the rootfs but you can use "--os-device-type generic" to override this, and you can also use "--console-device-type normal_and_serial" for both console types as well (I renamed the "--console-type" option to "--console-device-type").
For BIOS disk images for Proxmox the script will use VGA Text output (setting CADI_DEFAULT_CONSOLE_OUTPUT_TYPE="text") and for UEFI will use graphics output as UEFI does not support text output. |
I'm trying to build a proxmox image that can be deployed using either virtio or scsi for the block device, which I believe to be possible if the
os-device-type
is set togeneric
(from looking atmkinitfs-functions
)However, the script firstly doesn't allow
--os-device-type generic
, but also then the proxmox definitions don't allow it.Similar for
--console-type
- proxmox can supportnormal_and_serial
but the script doesn't allow it. (normal
console type is useful because it preserves history - theserial
console discards any console history prior to you opening the console)The text was updated successfully, but these errors were encountered: