Fix remaining calloc param reversals

gcc 14 identifies likely places where the sizeof() call is used for the first parameter to calloc(). This PR fixes the remaining places in the library where this occurs and reworks a few other allocations to be more uniform.
derobins · Oct 27, 2024 · 0a69091 · 0a69091
1 parent b8a06b5
commit 0a69091
Show file tree

Hide file tree

Showing 15 changed files with 123 additions and 6,192 deletions.
diff --git a/hl/src/H5TB.c b/hl/src/H5TB.c
@@ -3185,7 +3185,7 @@ H5TB_create_type(hid_t loc_id, const char *dset_name, size_t type_size, const si
     if (H5TBget_table_info(loc_id, dset_name, &nfields, NULL) < 0)
         goto out;
 
-    if (NULL == (fnames = (char **)calloc(sizeof(char *), (size_t)nfields)))
+    if (NULL == (fnames = (char **)calloc((size_t)nfields, sizeof(char *))))
         goto out;
 
     for (i = 0; i < nfields; i++)

diff --git a/src/H5Edefin.h b/src/H5Edefin.h
diff --git a/src/H5Einit.h b/src/H5Einit.h
diff --git a/src/H5Epubgen.h b/src/H5Epubgen.h
diff --git a/src/H5Eterm.h b/src/H5Eterm.h