New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL schemes should probably be globally whitelisted #6

Open

liquidsunshine opened this issue Aug 8, 2015 · 0 comments

Contributor

liquidsunshine commented Aug 8, 2015

URLs should probably be ignored altogether if they are a scheme we don't want to deal with (e.g. tel, javascript, etc.).

So rather than even putting them in to_visit in the first place, just throw them away.

Also, it probably makes sense to just have a whitelist that we can check each URL against, rather than a complex conditional tree.

liquidsunshine mentioned this issue

Better isolate scheme and mime detection logic #7

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment