Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-scoped tokens #990

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Auto-scoped tokens #990

wants to merge 13 commits into from

Conversation

peterthomassen
Copy link
Member

@peterthomassen peterthomassen commented Nov 19, 2024

Implementation of #885.

peterthomassen and others added 5 commits November 21, 2024 16:49
Updates the requirements on [django](https://github.com/django/django) to permit the latest version.
- [Commits](django/django@5.1.2...5.1.3)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [django-pgtrigger](https://github.com/Opus10/django-pgtrigger) to permit the latest version.
- [Release notes](https://github.com/Opus10/django-pgtrigger/releases)
- [Changelog](https://github.com/Opus10/django-pgtrigger/blob/main/CHANGELOG.md)
- [Commits](Opus10/django-pgtrigger@4.12.2...4.13.1)

---
updated-dependencies:
- dependency-name: django-pgtrigger
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [coverage](https://github.com/nedbat/coveragepy) to permit the latest version.
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.6.4...7.6.7)

---
updated-dependencies:
- dependency-name: coverage
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@peterthomassen
Copy link
Member Author

This almost fully implements #885. (Need to add creation of token policy upon domain creation when auto_policy=True, plus docs.)

Otherwise ready for review. (#886, #887 can be added later.)

@peterthomassen peterthomassen marked this pull request as ready for review November 21, 2024 15:52
@peterthomassen
Copy link
Member Author

Added a commit to complete #885.

@nils-wisiol nils-wisiol changed the title 20241104 eid tokens Auto-scoped tokens Nov 29, 2024
Copy link
Contributor

@nils-wisiol nils-wisiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

api/desecapi/permissions.py Outdated Show resolved Hide resolved
api/desecapi/views/domains.py Outdated Show resolved Hide resolved
api/desecapi/tests/test_token_domain_policy.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants