Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove need for json file #4

Open
phtj opened this issue Oct 22, 2019 · 0 comments
Open

remove need for json file #4

phtj opened this issue Oct 22, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@phtj
Copy link
Contributor

phtj commented Oct 22, 2019

At the moment we have a json file with some settings
This is used by teh grader for doing the grading

Creating this json file is more work, and error prone

Instead of a json file we can do the following:

  • The grader opens the answer model and checks what parameters there are
  • The grader randomly chooses some values for these parameters and executes the model
  • The grader checks the model attributes
    • If there is a model attribute called "answer_type=console", then it will set "console=true" and "model=false"
    • in all other cases it sets "console=false" and "model=true"
    • it always sets "normalize=true"
  • The grader executes the answer model
  • The grader applies the same parameters to the student model and executes it
  • The grader compares the models
@phtj phtj added the enhancement New feature or request label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants