You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For simulations, there is frequently a need to get the current "best estimate" of the nominal focalplane model. There are 2 easy ways (possibly more) that this could be implemented:
Have a special set of the focalplane ECSV files with a name like "nominal" in place of the date stamp. desimodel.io.load_focalplane() can recognize this string and return that instead of a normal date lookup / state log replay. This has the benefit of ensuring that any changes to the platescale file (for example) would be picked up automatically. Another benefit is that we could set this "nominal" focalplane to be the default. The downside would be a few lines of code to parse this special string, and downstream small changes in fiberassign to accept that special string. Things like the fiberassign unit tests would use this string everywhere.
Make a long-lived branch of the data svn for simulations. Put the nominal model there with a start date in the past so it is used for any time ever. Benefits are that no code changes are needed. The downsides are that any updates to other files like the platescale need to be copied to that branch manually and any users wanting that nominal model would have to get a local checkout of the branch and change their DESIMODEL environment variable to point to that instead. Fiberassign unit tests in travis would check out this data svn branch as well.
Both options require work. Option (1) would be least disruptive for most user workflows I think.
The text was updated successfully, but these errors were encountered:
Given what I'm hearing, it seems there's also interest in simulating a realistic fiber failure rate throughout the course of the survey. This would clearly prefer framework (2) I think. Is that at all feasible in the nearer term?
For simulations, there is frequently a need to get the current "best estimate" of the nominal focalplane model. There are 2 easy ways (possibly more) that this could be implemented:
Have a special set of the focalplane ECSV files with a name like "nominal" in place of the date stamp.
desimodel.io.load_focalplane()
can recognize this string and return that instead of a normal date lookup / state log replay. This has the benefit of ensuring that any changes to the platescale file (for example) would be picked up automatically. Another benefit is that we could set this "nominal" focalplane to be the default. The downside would be a few lines of code to parse this special string, and downstream small changes in fiberassign to accept that special string. Things like the fiberassign unit tests would use this string everywhere.Make a long-lived branch of the data svn for simulations. Put the nominal model there with a start date in the past so it is used for any time ever. Benefits are that no code changes are needed. The downsides are that any updates to other files like the platescale need to be copied to that branch manually and any users wanting that nominal model would have to get a local checkout of the branch and change their DESIMODEL environment variable to point to that instead. Fiberassign unit tests in travis would check out this data svn branch as well.
Both options require work. Option (1) would be least disruptive for most user workflows I think.
The text was updated successfully, but these errors were encountered: