Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize zcatalog.update_table_columns reordering #2369

Open
sbailey opened this issue Sep 11, 2024 · 0 comments
Open

generalize zcatalog.update_table_columns reordering #2369

sbailey opened this issue Sep 11, 2024 · 0 comments
Labels

Comments

@sbailey
Copy link
Contributor

sbailey commented Sep 11, 2024

desispec.update_table_columns makes some assumptions about the order of input columns while reordering the columns for output, while also trying to handle different *_TARGET columns in different inputs, etc. This is fragile if the input column order changes, e.g. #2363 . PR #2368 fixed the immediate problem while still having fragile assumptions about input column order for the more general case.

Revisit how that reordering is done and make the code robust to arbitrary input column order. Include unit tests to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant