Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove or fix desitarget.lyazcat #819

Open
sbailey opened this issue May 1, 2024 · 0 comments
Open

remove or fix desitarget.lyazcat #819

sbailey opened this issue May 1, 2024 · 0 comments

Comments

@sbailey
Copy link
Contributor

sbailey commented May 1, 2024

It appears that the functionality of desitarget.lyazcat has been replaced by the desispec creation of zmtl and qso_qn afterburner files (desispec.zmtl and desispec.scripts.qsoqn). If it really is unneeded, remove desitarget.lyazcat.

If we do really still need desitarget.lyazcat, it will need to be updated to support the quasarnp API changes in desihub/QuasarNP#7:

model, wavegrid = load_model(modelfilename)
blat = load_desi_coadd(coaddfilename, out_grid=wavegrid)

Previously there were hardcoded assumptions about the model wavelength grid; now the model files themselves specify what wavegrid was used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant