-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update masking to be "all-sky" using Gaia/Tycho/URAT #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…host Tycho files; some minor formatting fixes
…was the only one using them. Instead we'll use Gaia/Tycho to build masks
…aia; standardize healpix- file format throughout desitarget
…coordinates based on proper motions; build a bright star mask from Gaia and Tycho
…g the REF_ID for Tycho
…timize to run in pixel boundaries; update sloppy code style
…d in at file resolution instead of in the passed pixel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extensive refactor of the masking procedures in desitarget. It includes:
desitarget
to obtain and work with Tycho files.MASKBITS
information from the imaging catalogs.$MASK_DIR
(which, together with a$TYCHO_DIR
has been added to theetc/desitarget.module
manifest).test_brightmask
unit tests to be simpler and have more coverage.This should mostly address #471. It could also be used to address #103.