Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update masking to be "all-sky" using Gaia/Tycho/URAT #625

Merged
merged 25 commits into from
Jun 22, 2020

Conversation

geordie666
Copy link
Contributor

This PR is an extensive refactor of the masking procedures in desitarget. It includes:

  • General functionality in desitarget to obtain and work with Tycho files.
  • Deprecate using the sweeps to mask bright objects as this is now being done using the MASKBITS information from the imaging catalogs.
  • Functionality to allow bright star masks to be constructed at different epochs by accounting for proper motions of Tycho/Gaia/URAT sources.
  • Bright star masks are now explicitly written to a $MASK_DIR (which, together with a $TYCHO_DIR has been added to the etc/desitarget.module manifest).
  • The radius-magnitude relationship is now a single, straightforward function.
  • Refactoring of the test_brightmask unit tests to be simpler and have more coverage.
  • Skies and supplemental skies are now always masked by default.
  • A complete lack of backward compatibility (!), which I believe should be OK as the masking formalism wasn't yet being extensively used (while I waited on decisions on the imaging side).

This should mostly address #471. It could also be used to address #103.

…host Tycho files; some minor formatting fixes
…was the only one using them. Instead we'll use Gaia/Tycho to build masks
…aia; standardize healpix- file format throughout desitarget
…coordinates based on proper motions; build a bright star mask from Gaia and Tycho
…timize to run in pixel boundaries; update sloppy code style
…d in at file resolution instead of in the passed pixel
@geordie666 geordie666 merged commit 81a4759 into master Jun 22, 2020
@geordie666 geordie666 deleted the ADM-Gaia-Tycho-mask branch June 22, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant