Add project introduction #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschumac
reviewed
Jul 14, 2023
There was a problem hiding this comment.
Inhaltlich gehe ich mit der kurzen, aussagekräftigen Darstellung konform. Typos:
- "des OCLC-Katalogsystems", Bindestrich, da zusammengesetztes Substantiv
- "Mit Hilfe" statt "Mithilfe"
- In der index.md würde ich auch "Konkatenieren" wegen Substantivierung großschreiben.
mschumac
approved these changes
Jul 14, 2023
|
Ich schließe mich dem Review von @mschumac an, kurz und aussagekräftig, Prima. Vielleicht noch folgendes: Der Satz "Darüber hinaus eignet sich das Toolkit besonders für die Automatisierung von Metadaten-Workflows." verliert seine Wirkung nicht wenn das Adverb "besonders" gestrichen werden würde. |
san-uh
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vorschau: https://github.com/deutsche-nationalbibliothek/pica-rs/blob/docs-intro/docs/book/src/README.md
Review: https://github.com/deutsche-nationalbibliothek/pica-rs/pull/660/files#diff-a7abfd8d2b641f43f136f33cb55ec313aea94277aacef3f5440b906945ce86bf