Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include statusText in login exception message #52

Open
yeeliu01 opened this issue Apr 8, 2020 · 0 comments
Open

Include statusText in login exception message #52

yeeliu01 opened this issue Apr 8, 2020 · 0 comments

Comments

@yeeliu01
Copy link

yeeliu01 commented Apr 8, 2020

Logins may fail for different reasons. For example, one case:

[Fri Apr 3 19:23:28 2020]: (ComponentName) Pyrfa: (Severity) Error: [LoginHandler::processResponse] Login Status : dataState="Suspect" streamState="Closed" statusCode="Unknown RespCode" statusText="Access Denied-already using position 170.50.166.85"

[Fri Apr 3 19:23:28 2020]: (ComponentName) Pyrfa: (Severity) Error: 102 ([Pyrfa::login] Login failed. Please check data permission. (username: yee.liu))

Or another different case:

[Sat Mar 28 01:49:22 2020]: (ComponentName) Pyrfa: (Severity) Error: [LoginHandler::processResponse] Login Status : dataState="Suspect" streamState="Closed" statusCode="Unknown RespCode" statusText="yee123, unknown to system."

[Sat Mar 28 01:49:22 2020]: (ComponentName) Pyrfa: (Severity) Error: 102 ([Pyrfa::login] Login failed. Please check data permission. (username: yee123))

It would be more informative if we can include the "statusText" as above, in the login exception thrown by pyrfa.cpp#L421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yeeliu01