Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more thanks to give away - text change #7

Open
ashiazed opened this issue Sep 12, 2019 · 2 comments
Open

No more thanks to give away - text change #7

ashiazed opened this issue Sep 12, 2019 · 2 comments

Comments

@ashiazed
Copy link
Member

We need to adjust the text to remove the word burrito
You are trying to give away 1 burritos, but you only have 0 burritos left today!

@ashiazed ashiazed changed the title No more thanks to guve away No more thanks to give away - text change Sep 12, 2019
@MarkBennett
Copy link
Contributor

It looks like this specific text is coming from here:

this.sendToUser(giver, `You are trying to give away ${updates.length} burritos, but you only have ${diff} burritos left today!`)

The name burrito is used in a bunch of places (including to name objects in the code) so we should probably do a larger refactor to remove burrito references. We might want to pull all language resources out and then make an upstream PR.

@MarkBennett
Copy link
Contributor

Just doing a bit of research on possible translation libraries that work on node and in the browser. Some options include:

Based off of usage, ergonomics, and size it looks like polyglot.js might be the best choice.

format.js makes a better attempt to follow proposed (but not implemented) internationalization APIs which may come to the browser at some point, however it looks less ergonomic and seems a bit overcomplex for our current needs.

Both these libraries work in the browser and in Node.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants