Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden text issue in mobile view #32

Open
DimuthuLakmal opened this issue Mar 17, 2016 · 4 comments
Open

Hidden text issue in mobile view #32

DimuthuLakmal opened this issue Mar 17, 2016 · 4 comments
Labels

Comments

@DimuthuLakmal
Copy link

In mobile view some text are hidden in divs. I tried to correct it by changing css files. But i failed to correct it. Then i write some javascript code to detect screen width of the browser and change the layout according to it. Any other solution?
screenshot from 2016-03-17 12-12-54
screenshot from 2016-03-17 12-41-28

@asamalik
Copy link
Contributor

Hi, thank you for reporting. I like your proposed solution. If you manage to do that without javascript, I will be happy to accept your patch!

Example code for detecting screen width: (taken from our css)

@media all and (min-width: $screen-sm-min) {
  .title{
    #page-description p {
    font-size: 14pt !important;
    height: 115px;
    display: table-cell !important;
    vertical-align: middle !important;
    padding-top: 35px;
    }
  }
}

@media all and (max-width: $screen-xs-max) {
  .title{
    img.img-circle{
      padding: 3px;
      width: 50px;
    }
    h1 {
      margin-top: 40px;
      font-size: 1.8em;
    }
    #page-description p {
    font-size: 1em !important;
    height: 70px;
    display: table-cell !important;
    padding-top: 15px;
    }
  }
}

@asamalik asamalik added the bug label Mar 17, 2016
@DimuthuLakmal
Copy link
Author

Successfully done :)

@asamalik
Copy link
Contributor

Great!

However, I can not see your pull-request.

DimuthuLakmal added a commit to DimuthuLakmal/website that referenced this issue Mar 29, 2016
@DimuthuLakmal
Copy link
Author

Hi, Sorry about the delay. I made a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants