Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce code style with prettier and eslint. #136

Open
david-mateogit opened this issue Apr 3, 2020 · 3 comments
Open

Enforce code style with prettier and eslint. #136

david-mateogit opened this issue Apr 3, 2020 · 3 comments

Comments

@david-mateogit
Copy link

Hello.

I would like to test this project and later contribute if needed but I think this needs a prettier or eslint config to enforce the recommended code-style.

This worked on my build at the end of package.json, have to do more tests.

"prettier": { "printWidth": 120, "tabWidth": 1, "singleQuote": true, "trailingComma": "none", "semi": false }, "eslintConfig": { "parserOptions": { "ecmaVersion": 8, "sourceType": "module" }, "rules": { "semi": ["error", "never"] } }

I think some system like this would provide consistency and less headaches when people save and have auto format on vs code and such.

What do you think?

@rmariuzzo
Copy link
Member

rmariuzzo commented Apr 3, 2020 via email

@DannyFeliz
Copy link
Member

Hey @rmariuzzo could you please check this PR #133?

@david-mateogit
Copy link
Author

Sounds good to me

Great.
I'll do some tests and send a pr later.

BTW as a DR Dev I thank you for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants