Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What's the reason for peerDependencies? #139

Closed
Timer opened this issue Feb 17, 2019 · 3 comments
Closed

What's the reason for peerDependencies? #139

Timer opened this issue Feb 17, 2019 · 3 comments

Comments

@Timer
Copy link
Contributor

Timer commented Feb 17, 2019

Hi! What's the reason for having preact and react listed as peerDependencies in the * range?

This creates some unnecessary noise for users installing the package in their projects.

Would you accept a pull request removing these?
@Timer
Copy link
Contributor Author

Timer commented Feb 17, 2019

Actually, I just realized that unistore has integrations and requires the peer dependencies for newer features (e.g. Yarn PnP).

Could we use the new RFC and make these optional?

yarnpkg/rfcs#105

{
  "peerDependencies": {
    "preact": "optional:*",
    "react": "optional:*"
  }
}

@NathanielHill
Copy link

Yes please. 🙏

@developit developit mentioned this issue Feb 28, 2019
Merged
@Timer
Copy link
Contributor Author

Timer commented Mar 7, 2019

Looks like I didn't catch the change to the RFC. Please see PR: #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Timer @NathanielHill