Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob URL does not work on Node.js #30

Open
sindresorhus opened this issue Jun 26, 2022 · 3 comments · May be fixed by #32
Open

Blob URL does not work on Node.js #30

sindresorhus opened this issue Jun 26, 2022 · 3 comments · May be fixed by #32

Comments

@sindresorhus
Copy link

The readme says:

Worker() accepts a module URL, Blob URL or Data URL

But running the following on Node.js 18 results in a crash:

import Worker from 'web-worker';

const blob = new Blob(['foo'], {type: 'text/javascript'});
const url = URL.createObjectURL(blob);
const worker = new Worker(url, {type: 'module'});
node:internal/errors:466
    ErrorCaptureStackTrace(err);
    ^

TypeError [ERR_INVALID_URL_SCHEME]: The URL must be of scheme file
    at new NodeError (node:internal/errors:377:5)
    at Object.fileURLToPath (node:internal/url:1484:11)
    at new Worker (/Users/sindresorhus/dev/oss/make-asynchronous/node_modules/web-worker/cjs/node.js:108:19)
    at file:///Users/sindresorhus/dev/oss/make-asynchronous/x.js:5:16
    at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:409:24)
    at async loadESM (node:internal/process/esm_loader:85:5)
    at async handleMainPromise (node:internal/modules/run_main:61:12) {
  code: 'ERR_INVALID_URL_SCHEME'
}
@aaronhuggins
Copy link

Encountered the same issue in a private repo. Will link back once public.

@msikma
Copy link

msikma commented Aug 8, 2022

I too would love to have blob support.

Blob URLs are not available in the worker thread, so they need to be resolved prior to the thread being started. So the way to implement this would be to:

  • Resolve the object URL in the main thread to a Blob
  • Pass the resolved Blob on to the threads.Worker object directly
  • In parseDataUrl(), if the resolved Blob is defined, return {type: urlBlob.type, data: await urlBlob.text()}
  • Make the chain from parseDataUrl() async functions

Seems to work for me this way in a quick and dirty test, but I'm not sure if there are other details that need to be looked at.

@msikma msikma linked a pull request Aug 8, 2022 that will close this issue
Open
@jimmywarting
Copy link

Transfering disc based blobs (from fs.openAsBlob(path)) are not transferable to other threads. therefore it might be better to just resolve the blob.text() in the main tread and pass the actual code to the worker rather than transferring a blob.

an alternative could be to read it as blob.arrayBuffer() cuz this can be transfered (zero-copied) over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Blob URLs for Node (experiment) msikma/web-worker
4 participants
@sindresorhus @jimmywarting @msikma @aaronhuggins