Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit cdk libs version #93

Closed
vincentsarago opened this issue Feb 21, 2024 · 2 comments · Fixed by #97
Closed

limit cdk libs version #93

vincentsarago opened this issue Feb 21, 2024 · 2 comments · Fixed by #97

Comments

@vincentsarago
Copy link
Member

I'm not sure how it works in node but In python

"@aws-cdk/aws-apigatewayv2-integrations-alpha": "^2.47.0-alpha.0",

will be translated to

aws-cdk.aws-apigatewayv2-integrations-alpha (<3.0.0,>=2.47.0.a0)

eoapi-cdk/package.json

Lines 53 to 57 in 17eec16

"@aws-cdk/aws-apigatewayv2-integrations-alpha": "^2.47.0-alpha.0",
"@aws-cdk/aws-lambda-python-alpha": "^2.47.0-alpha.0",
"aws-cdk-lib": "^2.99.1",
"constructs": "^10.1.113",
"module": "^1.2.5"

@emileten
Copy link
Contributor

Sounds like the behavior is the same in node https://stackoverflow.com/a/22345808/12357157

So we can close ? Or I misunderstood the ticket ?

@vincentsarago
Copy link
Member Author

@emileten the issue is that this open requirement is a bit too open IMO. the cdk library is moving fast and I feel there could be micro breaking changes between minor version.

If we assume all the cdk-libs requirement are coming from eoapi-cdk, I think we could pin the libs to a specific version

@emileten emileten mentioned this issue Feb 23, 2024
1 task
@emileten emileten linked a pull request Feb 23, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants