From 75f8a8374da9de96a7fcf4ab904581619894b2de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrik=20Novotn=C3=BD?= Date: Thu, 21 Feb 2019 13:39:23 +0100 Subject: [PATCH] Warn about possible glibc collation changes * bin/postgresql-setup.in: Print warning about possible glibc collation on successful upgrade. --- NEWS | 3 +++ bin/postgresql-setup.in | 10 ++++++++++ 2 files changed, 13 insertions(+) diff --git a/NEWS b/NEWS index 11e98ca..4f4e95e 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,9 @@ New in 8.3 version: +* postgresql-setup prints warning about possible glibc collation on + successful upgrade. + * postgresql-setup creates correct 'log_directory' based on PG version (the default changed from $datadir/pg_log to $datadir/log in v10). diff --git a/bin/postgresql-setup.in b/bin/postgresql-setup.in index 3639577..bb34721 100644 --- a/bin/postgresql-setup.in +++ b/bin/postgresql-setup.in @@ -121,6 +121,14 @@ Environment: PGSETUP_DEBUG Set to '1' if you want to see very verbose shell debugging output." +# Warning about possible glibc collation changes BZ#1668301 +GLIBC_COLLATION_WARN_STRING="\ +WARNING: If you've just upgraded your database from a previous major +version of Fedora or RHEL, please run reindexdb against your databases. +Core library collation data may have changed and this will invalidate +database indexes. For example, in Fedora 28 and RHEL 8 there have been +extensive changes in glibc collations to support ISO 14651:2016 (Unicode +9.0.0 data) and your indexes may be affected: https://sourceware.org/ml/libc-announce/2018/msg00002.html" print_version() { @@ -343,6 +351,8 @@ upgrade() warn $"The configuration files were replaced by default configuration." warn $"The previous configuration and data are stored in folder" warn $pgdataold. + # Warn about possible glibc collation changes on success BZ#1668301 + warn "$GLIBC_COLLATION_WARN_STRING" else # Clean up after failure. $failure_cleanup && rm -rf "$pgdata"