Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink editing enabled/disabled #337

Open
developster opened this issue Nov 13, 2020 · 0 comments
Open

Rethink editing enabled/disabled #337

developster opened this issue Nov 13, 2020 · 0 comments

Comments

@developster
Copy link
Contributor

Right now, whenever a form component is enabled or disabled is controlled by firing EditingDisabledEvent or EditingEnabledEvent from the page.

This does not cover the case if the form will have new inputs rendered after the event was fired. For example when only a part of the form is updated, then newly added form components may be out of sync with the rest of the form components that were rendered on page load.

Maybe we can make the form be the controller, and if form is enabled then all form components will honor this setting, and vice versa, when form is disabled component will be disabled as well. This could be a behavior, if attached to a form component will control its enabled flag by looking at the form.

It is a low priority task because we don't have any current issues related to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant