Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retaining legacy API when reversing reference between Grid and SubDomain prevents solve cache from clearing #2298

Open
EdCaunt opened this issue Jan 23, 2024 · 0 comments

Comments

@EdCaunt
Copy link
Contributor

EdCaunt commented Jan 23, 2024

To implement Functions on SubDomains, the reference between Grid and SubDomain must be reversed such that SubDomains have a parent Grid. However, to avoid breaking existing codes, the legacy API wherein SubDomains are passed to Grid on instantiation must be retained. This creates a circular reference between Grid and SubDomain, preventing the cache from clearing. When the legacy API is removed, tests/test_caching.py::TestMemoryLeaks::test_solve should be updated to reflect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant