fix bug where save size could be detected incorrectly, if multiple bytes in the save are identical #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter0x44
force-pushed
the
fix-eepromsize-detection
branch
from
e96e8c7 to
e63e99f
Compare
|
I force pushed to change some formatting - I accidentally used spaces instead of tabs in some places |
…e bytes in the save are identical
Peter0x44
force-pushed
the
fix-eepromsize-detection
branch
from
e63e99f to
2479054
Compare
Before, 128k saves (like those present in Pokemon Mystery Dungeon: Explorers of Sky would be detected incorrectly as 8k saves. Also, the first byte read from them would always be 0xFF
|
Another user ran in to a different issue with dumping saves - the code didn't handle 128k eeprom properly I'm going to throw that change in here, hopefully someone can get around to reviewing it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, a user of GodMode9i reported that it was always dumping only the first 8192 bytes of save, as the function cardEepromGetSize was reporting the wrong value, instead of the 64k which the save should have been.
Flashing this save to another cartridge also caused the size to be detected incorrectly, so it was nothing with the flash type itself
What causes this here is that both the first and 8192nd words are 0, so it just stops looping early
By writing TeST (a very unlikely value to appear later on) and restoring it after finishing the loop, the size is now detected correctly.
SCRIBLENAUT2_BH2EWR_0.zip