Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: are you checking module and package names? #71

Closed
sobolevn opened this issue Feb 15, 2018 · 2 comments
Closed

Question: are you checking module and package names? #71

sobolevn opened this issue Feb 15, 2018 · 2 comments

Comments

@sobolevn
Copy link

Sorry, I might have missed either are you checking module or package names or not.

Just to make it clear: package and module names should be all lowercase with _ as possible separator. It is also wise to check maximum length of names.

There's a plugin for flake8 for this: https://pypi.python.org/pypi/flake8-module-name/0.1.5

Here's a usage example: https://github.com/wemake-services/wemake-django-template/blob/master/%7B%7Bcookiecutter.project_name%7D%7D/Pipfile#L26

P.S. You have almost completely reinvented all possible flake8 plugins.
P.S.S. I am obsessed with code quality and coding styling, so I am going to steal some rules from you and make it as a separate flake8 plugins.

@vergeev
Copy link
Contributor

vergeev commented Feb 15, 2018

It turns out, we do not check the module/package names at all. Thanks for pointing that out!

@Melevir
Copy link
Contributor

Melevir commented Feb 15, 2018

The validator will be added in #72

@Melevir Melevir closed this as completed Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants