From af3c4ef4849824d4ea58814d1e13e4732612d763 Mon Sep 17 00:00:00 2001 From: alfeilex <101652401+alfeilex@users.noreply.github.com> Date: Mon, 11 Nov 2024 18:47:15 +0100 Subject: [PATCH] #315: Fix frozen process after global tool installation with msiexec (#684) --- CHANGELOG.adoc | 1 + .../java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index 3412d1bf7..e019a6f48 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -18,6 +18,7 @@ The full list of changes for this release can be found in https://github.com/dev Release with new features and bugfixes: +* https://github.com/devonfw/IDEasy/issues/315[#315]: Fix frozen process after MSI installation * https://github.com/devonfw/IDEasy/issues/312[#312]: Add ability to prefer git (ssh) protocol instead of https for cloning repo * https://github.com/devonfw/IDEasy/issues/685[#685]: Upgrades and cleanup of dependencies and according license and doc * https://github.com/devonfw/IDEasy/pull/693[#693]: Setup not working on Mac diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java b/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java index 9a5bb6d92..8bcd676e5 100644 --- a/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java +++ b/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java @@ -13,6 +13,7 @@ import com.devonfw.tools.ide.process.EnvironmentContext; import com.devonfw.tools.ide.process.ProcessContext; import com.devonfw.tools.ide.process.ProcessErrorHandling; +import com.devonfw.tools.ide.process.ProcessMode; import com.devonfw.tools.ide.repo.ToolRepository; import com.devonfw.tools.ide.version.VersionIdentifier; @@ -141,7 +142,7 @@ public boolean install(boolean silent, EnvironmentContext environmentContext) { executable = fileAccess.findFirst(downloadBinaryPath, Files::isExecutable, false); } ProcessContext pc = this.context.newProcess().errorHandling(ProcessErrorHandling.LOG_WARNING).executable(executable); - int exitCode = pc.run(); + int exitCode = pc.run(ProcessMode.BACKGROUND).getExitCode(); if (tmpDir != null) { fileAccess.delete(tmpDir); }