From a1efd4acf5244dcd688f3a28ff921626cfe33864 Mon Sep 17 00:00:00 2001 From: alfeilex <101652401+alfeilex@users.noreply.github.com> Date: Wed, 9 Oct 2024 16:26:15 +0200 Subject: [PATCH 1/4] #315: Fix frozen process after MSI installation --- .../java/com/devonfw/tools/ide/process/ProcessContextImpl.java | 1 + 1 file changed, 1 insertion(+) diff --git a/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java b/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java index 7ccfeaab3..97c3641e0 100644 --- a/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java +++ b/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java @@ -304,6 +304,7 @@ private String addExecutable(String exec, List args) { } if ("msi".equalsIgnoreCase(fileExtension)) { args.add(0, "/i"); + args.add(0, "/qb"); args.add(0, "msiexec"); } args.add(exec); From 993a0ae5e02e3f05529222e75c05dd487f19aef7 Mon Sep 17 00:00:00 2001 From: alfeilex <101652401+alfeilex@users.noreply.github.com> Date: Thu, 10 Oct 2024 12:33:47 +0200 Subject: [PATCH 2/4] Update changelog --- CHANGELOG.adoc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index 8f9fb9c07..e4def4e8f 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -2,6 +2,12 @@ This file documents all notable changes to https://github.com/devonfw/IDEasy[IDEasy]. +== 2024.10.001 + +Release with new features and bugfixes: + +* https://github.com/devonfw/IDEasy/issues/315[#315]: #315: Fix frozen process after MSI installation + == 2024.09.002 Release with new features and bugfixes: From 14e7c6f18bdfb0c5b7c520b7a3dec12eb87f6e7a Mon Sep 17 00:00:00 2001 From: alfeilex <101652401+alfeilex@users.noreply.github.com> Date: Thu, 10 Oct 2024 12:35:15 +0200 Subject: [PATCH 3/4] fix type --- CHANGELOG.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index e4def4e8f..c39559290 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -6,7 +6,7 @@ This file documents all notable changes to https://github.com/devonfw/IDEasy[IDE Release with new features and bugfixes: -* https://github.com/devonfw/IDEasy/issues/315[#315]: #315: Fix frozen process after MSI installation +* https://github.com/devonfw/IDEasy/issues/315[#315]: Fix frozen process after MSI installation == 2024.09.002 From 1ee8d4a40fb63386c4001c86cf58b26ecd3f084c Mon Sep 17 00:00:00 2001 From: alfeilex <101652401+alfeilex@users.noreply.github.com> Date: Tue, 29 Oct 2024 13:23:19 +0100 Subject: [PATCH 4/4] revert qn argument and change processmode of run of global tools to background mode --- .../java/com/devonfw/tools/ide/process/ProcessContextImpl.java | 1 - .../java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java b/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java index 97c3641e0..7ccfeaab3 100644 --- a/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java +++ b/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java @@ -304,7 +304,6 @@ private String addExecutable(String exec, List args) { } if ("msi".equalsIgnoreCase(fileExtension)) { args.add(0, "/i"); - args.add(0, "/qb"); args.add(0, "msiexec"); } args.add(exec); diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java b/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java index 961846709..9b7a71f2a 100644 --- a/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java +++ b/cli/src/main/java/com/devonfw/tools/ide/tool/GlobalToolCommandlet.java @@ -13,6 +13,7 @@ import com.devonfw.tools.ide.process.EnvironmentContext; import com.devonfw.tools.ide.process.ProcessContext; import com.devonfw.tools.ide.process.ProcessErrorHandling; +import com.devonfw.tools.ide.process.ProcessMode; import com.devonfw.tools.ide.repo.ToolRepository; import com.devonfw.tools.ide.version.VersionIdentifier; @@ -131,7 +132,7 @@ public boolean install(boolean silent, EnvironmentContext environmentContext) { executable = fileAccess.findFirst(downloadBinaryPath, Files::isExecutable, false); } ProcessContext pc = this.context.newProcess().errorHandling(ProcessErrorHandling.LOG_WARNING).executable(executable); - int exitCode = pc.run(); + int exitCode = pc.run(ProcessMode.BACKGROUND).getExitCode(); if (tmpDir != null) { fileAccess.delete(tmpDir); }