Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional toggle for the space character #30

Open
kylehakala opened this issue Oct 24, 2018 · 6 comments
Open

Add optional toggle for the space character #30

kylehakala opened this issue Oct 24, 2018 · 6 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@kylehakala
Copy link

The toggle for any style of password/phrase is important due to of a lack of consistency in systems supporting spaces or no-spaces in their password requirements.

@devshawn devshawn added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 25, 2018
@CapitanFindusFI
Copy link

hi @kylehakala, so you just need a toggle for implementing space character inside your random generator?

@kylehakala
Copy link
Author

kylehakala commented Oct 25, 2018 via email

@CapitanFindusFI
Copy link

@kylehakala ok, I'm on it

@CapitanFindusFI
Copy link

@kylehakala the password-generator library that you're using doesn't include the whitespace character while listing all available chars, so I'm pretty sure it won't ever consider it while writing its random password. Anyway, I could proceed writing whitespaces at random positions inside your string, but it won't be a really good solution imho

@kylehakala
Copy link
Author

kylehakala commented Oct 26, 2018

@CapitanFindusFI it’s not my project, so as far as I’m concerned, it could be implemented however you see appropriate. But it would probably be best to write this in a way such that the code can be used to add spaces between specific parts of the text to help advance the passphrase feature. @devshawn what say you?

@kylehakala
Copy link
Author

@CapitanFindusFI Did you ever jump into this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants